Skip to content

Commit

Permalink
fix: make Wasm upstream overrides dependent on arch(wasm32) (#1191)
Browse files Browse the repository at this point in the history
  • Loading branch information
dhess authored Nov 30, 2023
2 parents ad649fb + afbb312 commit 9865b85
Showing 1 changed file with 33 additions and 25 deletions.
58 changes: 33 additions & 25 deletions cabal.project
Original file line number Diff line number Diff line change
Expand Up @@ -45,32 +45,40 @@ source-repository-package
--sha256: 0q8m8asmb83mpa3j3adlrhc446xif7gv6lql20gv05k33lmbjfhg

-- Wasm workarounds.
--
-- We would prefer that these workarounds were not Wasm-dependent;
-- i.e., that we would use the same version of these dependencies
-- whether we're building for Wasm or not. However, we *do* make them
-- Wasm-dependent, because haskell.nix cannot build any of these
-- source-repository-package dependencies, *nor their reverse
-- dependencies*, using Nix while in the Nix development shell.

-- Upstream requires `happy` at build time, which doesn't work on Wasm
-- targets.
source-repository-package
type: git
location: https://github.com/hackworthltd/pretty-show
tag: 91d119cb0e3c5f7d866589b25158739580c8fc88
--sha256: sha256-mu8Eq0Sg6nCF8C2sXB6ebZcLhz8TVZAbNMiorA7RVc8=
-- if arch(wasm32)
-- -- Upstream requires `happy` at build time, which doesn't work on Wasm
-- -- targets.
-- source-repository-package
-- type: git
-- location: https://github.com/hackworthltd/pretty-show
-- tag: 91d119cb0e3c5f7d866589b25158739580c8fc88
-- --sha256: sha256-mu8Eq0Sg6nCF8C2sXB6ebZcLhz8TVZAbNMiorA7RVc8=

-- Upstream depends on Posix types unavailable in Wasm.
source-repository-package
type: git
location: https://github.com/hackworthltd/semirings
tag: 369f696d9d00fe004b16b0de08888fee7a3d08c3
--sha256: sha256-kkHCp4Y9IqMXGaDyW5UpsmRjy0ZWZkVSo1nOhpgZUQ0=
-- -- Upstream depends on Posix types unavailable in Wasm.
-- source-repository-package
-- type: git
-- location: https://github.com/hackworthltd/semirings
-- tag: 369f696d9d00fe004b16b0de08888fee7a3d08c3
-- --sha256: sha256-kkHCp4Y9IqMXGaDyW5UpsmRjy0ZWZkVSo1nOhpgZUQ0=

-- Upstream uses custom setup, which breaks on Wasm.
source-repository-package
type: git
location: https://github.com/cdepillabout/pretty-simple
tag: 6fb9b281800ad045925c7344ceb9fd293d86c3b9
--sha256: sha256-1gsYj/iznEUCeQ1f5Xk7w54h9FLJSNrIR9V3p4eaRYk=
-- -- Upstream uses custom setup, which breaks on Wasm.
-- source-repository-package
-- type: git
-- location: https://github.com/cdepillabout/pretty-simple
-- tag: 6fb9b281800ad045925c7344ceb9fd293d86c3b9
-- --sha256: sha256-1gsYj/iznEUCeQ1f5Xk7w54h9FLJSNrIR9V3p4eaRYk=

-- Upstream doesn't want to support Wasm while it's "experimental."
source-repository-package
type: git
location: https://github.com/amesgen/splitmix
tag: 83b906c4bcdc2720546f1779a16eb65e8e12ecba
--sha256: sha256-sR+Ne56SBzVbPfC7AJeQZn20YDfFwBDpRI873cTm1nU=
-- -- Upstream doesn't want to support Wasm while it's "experimental."
-- source-repository-package
-- type: git
-- location: https://github.com/amesgen/splitmix
-- tag: 83b906c4bcdc2720546f1779a16eb65e8e12ecba
-- --sha256: sha256-sR+Ne56SBzVbPfC7AJeQZn20YDfFwBDpRI873cTm1nU=

1 comment on commit 9865b85

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Primer benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 9865b85 Previous: ad649fb Ratio
evalTestM/pure logs/mapEven 1: outlier variance 0.15349951955053118 outlier variance 0.02629656683710734 outlier variance 5.84
typecheck/mapOdd 10: outlier variance 0.35581074788191913 outlier variance 0.08722144642811536 outlier variance 4.08
typecheck/mapOddPrim 10: outlier variance 0.1320325391273207 outlier variance 0.01694411414982164 outlier variance 7.79

This comment was automatically generated by workflow using github-action-benchmark.

CC: @dhess

Please sign in to comment.