Usernames with dash/hypen characters are no longer allowed when creating users #14840
Labels
needs-triage
A brand new issue that needs triaging.
Comments
chrisvittal
pushed a commit
to chrisvittal/hail
that referenced
this issue
Mar 27, 2025
## Change Description Addresses hail-is#14840 by allowing well-placed hyphens in usernames again. Not required for the Broad deployment but is perfectly safe to do, and was blocking external collaborators whose usernames frequently require hyphens. ## Security Assessment - This change has a medium security impact ### Impact Description Modifies the set of usernames allowed, but only by allowing well-placed individual hyphens, which will still produce "url valid" downstream resource names. (Reviewers: please confirm the security impact before approving)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
What happened?
As of the 0.2.134 release, and the inclusion of PR #14808, the create user API endpoint no longer accepts usernames with a hyphen in them, eg.
test-user-123.This line is the specific change that that disallows any non alphanumeric characters in usernames:
https://github.com/hail-is/hail/pull/14808/files#diff-8cbb3ae1b62d4b6aca0786b36059eb82622ca4e7ee98e4a7fb5b39b7f38379e9L131
We unfortunately have many usernames with hyphens. I understand from #14808 that the validation change is intended to resolve the issue of users being created with invalid usernames and causing problems down the line, and specifically to avoid usernames with uppercase letters. Would it be possible to slightly relax this validation to allow lowercase alphanumeric and hyphens?
We have temporarily rolled back this change on our end, so this isn't a blocker for us currently.
populationgenomics#362
Version
0.2.134
The text was updated successfully, but these errors were encountered: