Skip to content

ASCReader does not support ASC format since V8.1 #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tian-Jionglu opened this issue Mar 3, 2023 · 2 comments
Open

ASCReader does not support ASC format since V8.1 #1531

Tian-Jionglu opened this issue Mar 3, 2023 · 2 comments
Labels

Comments

@Tian-Jionglu
Copy link

Describe the bug

ASCReader in python-can 4.1.0 doesn't support ASC CANFD format since V8.1, since <symbolic_name> name is missing in code.
According to the document from Vector <can_log_trigger_asc_format.pdf>, there should be <SYMBOLIC_NAME> between <ID> and <BRS>.

To Reproduce

Use python-can to read CANFD message in asc log since format V8.1.

Expected behavior

Reading process stopped with CANFD message.

Additional context

I made a quick fix in a forked branch.
I think an overall fix about ASC format IO is needed in this issue.

OS and version:
Python version:
python-can version:
python-can interface/s (if applicable):

Traceback and logs
@zariiii9003
Copy link
Collaborator

Since you have the format description, could you provide a backwards compatible solution as a PR?

@Tian-Jionglu
Copy link
Author

see PR #1641 , cause of my misunderstanding of ASC logging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants