Skip to content

Make Message a dataclass #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make Message a dataclass #1844

wants to merge 1 commit into from

Conversation

NickCao
Copy link
Contributor

@NickCao NickCao commented Aug 26, 2024

No description provided.

@NickCao
Copy link
Contributor Author

NickCao commented Aug 26, 2024 •
edited
Loading

weakref_slot is only available in python >= 3.11.

@NickCao NickCao marked this pull request as draft August 26, 2024 20:49
@NickCao NickCao marked this pull request as ready for review August 26, 2024 21:24
@zariiii9003
Copy link
Collaborator

The performance impact is not worth the benefits as of now, so i'm going to close this.
We can come back to this once python 3.11 is the minimum supported version of python-can.

@zariiii9003 zariiii9003 closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickCao @zariiii9003