Enable pylint on Travis CI builds #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run pylint on all Travis CI builds for rules that we currently are conformant to. This adds a .pylintrc-wip file, which is intended to be a temporary stop-gap that contains the current rules that the project is conformant to. This allows us to incrementally enable pylint rules and have them them enforced in subsequent code, rather than fixing the violations all at once. The .pylintrc file is intended to be the file containing all the preferred set of rules that the project will eventually be compliant against.
Codecov Report
@@ Coverage Diff @@
## develop #592 +/- ##
========================================
Coverage 59.97% 59.97%
========================================
Files 63 63
Lines 5572 5572
========================================
Hits 3342 3342
Misses 2230 2230 |
felixdivo
reviewed
May 18, 2019
|
|
||
| # Use multiple processes to speed up Pylint. Specifying 0 will auto-detect the | ||
| # number of processors available to use. | ||
| jobs=1 |
There was a problem hiding this comment.
Maybe use 0 since we might run it on our local multicore systems?
There was a problem hiding this comment.
Sorry, I was out of town for the last few days. Do you still want me to change this?
There was a problem hiding this comment.
It's not too important. We can just do it next time we remove some other exclusions.
felixdivo
approved these changes
May 18, 2019
felixdivo
added
the
QA
|
This fixes #579, right? |
|
This PR only addresses the linter aspect of #579. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run pylint on all Travis CI builds for rules that we currently are
conformant to.
This adds a .pylintrc-wip file, which is intended to be a temporary
stop-gap that contains the current rules that the project is conformant
to. This allows us to incrementally enable pylint rules and have them
them enforced in subsequent code, rather than fixing the violations all
at once.
The .pylintrc file is intended to be the file containing all the
preferred set of rules that the project will eventually be compliant
against.
Currently the
.pylintrcfiles are generated via the default rules:I don't really have a preference in terms of which linter is being
used, so let me know if you feel strongly about a particular linter.