Skip to content

Server API (and crate seperation) #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yusdacra opened this issue Dec 21, 2020 · 1 comment
Closed

Server API (and crate seperation) #4

yusdacra opened this issue Dec 21, 2020 · 1 comment

Comments

@yusdacra
Copy link
Member

It's probably best to seperate the stuff into seperate crates. Probably:

  • harmony_api: holds generated api code (control server / client code generation via a feature)
  • harmony_api_macros: macros we'll use in api crates
  • harmony_client_api: client api methods, client: &Client should be made generic using something like AsMut<...Service> instead
  • harmony_federation_api: same as above but for server
  • harmony_client_stateless: stateless client feat: seperate client frameworks #3
  • harmony_client_stateful: stateful client feat: seperate client frameworks #3

and a harmony crate which re-exports these controlled with feature gates. Pretty much like ruma structure.

@yusdacra
Copy link
Member Author

Decided this isn't really needed nor useful since we use macros and generated API code, which makes our code more concise. We can still use feature gates to disable client etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant