Testing

Author: Rafal Ksiazek

config/application.config.php

@@ -5,6 +5,7 @@
         'DoctrineModule',
         'DoctrineORMModule',
         'DluTwBootstrap',
+        'Acl',
         'Auth',
         'Application',
         'User',

module/Auth/test/AuthTest/Controller/LoginControllerTest.php

@@ -163,4 +163,38 @@ public function testAction_WithExceptionInService()
         $this->assertNotRedirect();
     }
 
+    public function testAction_WhenLoginIsFailed()
+    {
+        $data = [
+            'login' => uniqid('login'),
+            'password' => uniqid('password'),
+            'csrf' => 'csrfToken'
+        ];
+
+        $inputFilterMock = $this->getMock(InputFilterInterface::class);
+
+        $this->loginFormMock->expects($this->once())
+            ->method('setData')->with($data);
+
+        $this->loginFormMock->expects($this->once())
+            ->method('isValid')->will($this->returnValue(true));
+
+        $this->loginFormMock->expects($this->once())
+            ->method('getInputFilter')->will($this->returnValue($inputFilterMock));
+
+        $this->loginService->expects($this->once())
+            ->method('login')
+            ->with($inputFilterMock)
+            ->will($this->returnValue(false));
+
+        $this->controller->dispatch(
+            (new Request())
+                ->setMethod(Request::METHOD_POST)
+                ->setPost(new Parameters($data))
+        );
+
+        $this->assertResponseStatusCode(Response::STATUS_CODE_200);
+        $this->assertNotRedirect();
+    }
+
 }

module/Auth/test/AuthTest/Service/Storage/DbStorageTest.php

@@ -49,13 +49,14 @@ public function testWriteAndReadAndClear()
             ->will($this->returnValue($userEntity));
 
         $result = $this->testedObject->read();
+        $this->assertSame($userEntity, $result);
 
+        // read again without searching in repository
+        $result = $this->testedObject->read();
         $this->assertSame($userEntity, $result);
 
         $this->testedObject->clear();
-
         $result = $this->testedObject->read();
-
         $this->assertSame(null, $result);
     }
 

module/Library/test/LibraryTest/Repository/BookRepositoryTest.php

@@ -2,8 +2,10 @@
 
 namespace LibraryTest\Repository;
 
+use Application\Library\QueryFilter\Exception\UnrecognizedFieldException;
+use Application\Library\QueryFilter\Exception\UnsupportedTypeException;
 use Application\Library\QueryFilter\QueryFilter;
-use Application\Library\QueryFilter\Command\Repository;
+use Application\Library\QueryFilter\Command;
 use Doctrine\ORM\Query;
 use Doctrine\ORM\QueryBuilder;
 use DoctrineModule\Stdlib\Hydrator\DoctrineObject;
@@ -13,7 +15,7 @@
 use PHPUnit_Framework_MockObject_MockObject as MockObject;
 use Test\Bootstrap;
 
-class BookRepositoryTestCase extends AbstractRepositoryTestCase
+class BookRepositoryTest extends AbstractRepositoryTestCase
 {
     /**
      * @var BookRepository
@@ -152,7 +154,7 @@ public function testDelete_WithoutFlush()
         $this->testedObj->delete($bookEntity, false);
     }
 
-    public function testFindByQueryFilter()
+    public function testFindByQueryFilter_WithValidQueryData()
     {
         $sm = Bootstrap::getServiceManager();
 
@@ -188,7 +190,7 @@ public function testFindByQueryFilter()
         $queryFilter = $sm->get(QueryFilter::class);
         $queryFilter->setQueryParameters($queryData);
 
-        $commandCollection = $sm->get(Repository\CommandCollection::class);
+        $commandCollection = $sm->get(Command\Repository\CommandCollection::class);
 
         $this->classMetadataMock->expects($this->any())
             ->method('getFieldNames')
@@ -213,4 +215,69 @@ public function testFindByQueryFilter()
 
         $this->testedObj->findByQueryFilter($queryFilter, $commandCollection);
     }
+
+    public function testFindByQueryFilter_WithNotFoundCriteriaCommand()
+    {
+        $sm = Bootstrap::getServiceManager();
+
+        $queryData = [
+            '$fields' => 'id,author,title',
+        ];
+
+        $fieldNames = [
+            'id',
+            'author',
+            'title',
+            'year',
+            'price',
+            'name',
+            'status'
+        ];
+
+        /** @var QueryFilter $queryFilter */
+        $queryFilter = $sm->get(QueryFilter::class);
+        $queryFilter->setQueryParameters($queryData);
+
+        $commandCollection = new Command\Repository\CommandCollection(
+            [
+                new Command\Repository\BetweenCommand()
+            ]
+        );
+
+        $this->classMetadataMock->expects($this->any())
+            ->method('getFieldNames')
+            ->will($this->returnValue($fieldNames));
+
+        $this->setExpectedException(UnsupportedTypeException::class, 'Unsupported condition type: fields');
+
+        $this->testedObj->findByQueryFilter($queryFilter, $commandCollection);
+    }
+
+    public function testFindByQueryFilter_WithUnrecognizedField()
+    {
+        $sm = Bootstrap::getServiceManager();
+
+        $queryData = [
+            '$fields' => 'id,author,title',
+        ];
+
+        $fieldNames = [
+            'author',
+            'title',
+        ];
+
+        /** @var QueryFilter $queryFilter */
+        $queryFilter = $sm->get(QueryFilter::class);
+        $queryFilter->setQueryParameters($queryData);
+
+        $commandCollection = $sm->get(Command\Repository\CommandCollection::class);
+
+        $this->classMetadataMock->expects($this->any())
+            ->method('getFieldNames')
+            ->will($this->returnValue($fieldNames));
+
+        $this->setExpectedException(UnrecognizedFieldException::class, 'Field unrecognized in entity: id');
+
+        $this->testedObj->findByQueryFilter($queryFilter, $commandCollection);
+    }
 }

module/User/test/UserTest/Entity/UserEntityTest.php

@@ -0,0 +1,63 @@
+<?php
+
+namespace UserTest\Entity;
+
+use User\Entity\UserEntity;
+
+class UserEntityTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * @var UserEntity
+     */
+    private $testedObject;
+
+    public function setUp()
+    {
+        $this->testedObject = new UserEntity();
+    }
+
+    public function testInstance()
+    {
+        $this->assertNull($this->testedObject->getId());
+    }
+
+    public function testSetAndGetName()
+    {
+        $value = uniqid('name');
+
+        $this->testedObject->setName($value);
+        $result = $this->testedObject->getName();
+
+        $this->assertSame($value, $result);
+    }
+
+    public function testSetAndGetLogin()
+    {
+        $value = uniqid('login');
+
+        $this->testedObject->setLogin($value);
+        $result = $this->testedObject->getLogin();
+
+        $this->assertSame($value, $result);
+    }
+
+    public function testSetAndGetEmail()
+    {
+        $value = uniqid('email');
+
+        $this->testedObject->setEmail($value);
+        $result = $this->testedObject->getEmail();
+
+        $this->assertSame($value, $result);
+    }
+
+    public function testSetAndGetPassword()
+    {
+        $value = uniqid('password');
+
+        $this->testedObject->setPassword($value);
+        $result = $this->testedObject->getPassword();
+
+        $this->assertSame($value, $result);
+    }
+}