feat: add grants tests for billing resource #5559
Open
+255
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add test coverage for testing grants with billing resource. This tests `monthly-active-users` action with billing. billing does not support output_fields so there are no tests for that
bosorawis
approved these changes
Feb 21, 2025
bosorawis
reviewed
Feb 24, 2025
| @@ -84,6 +86,36 @@ func TestGrants_ReadActions(t *testing.T) { | |||
| }, | |||
| wantErr: handlers.ApiErrorWithCode(codes.PermissionDenied), | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
are changes to this file accidentally committed?
There was a problem hiding this comment.
The tests should be for billing resource rather. Added that mistakenly. This is what happens when you're jumping from one test to another 😅. Just pushed a change to address this
bosorawis
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add test coverage for testing grants with billing resource. This tests
monthly-active-usersaction with billing.billing does not support
output_fieldsso there are no tests for that