Disable @typescript-eslint errors to facilitate the upgrade

Recorded in https://hashicorp.atlassian.net/browse/HDS-4656

Author: alex-ju

packages/components/src/components/hds/advanced-table/expandable-tr-group.ts

@@ -76,7 +76,7 @@ export default class HdsAdvancedTableExpandableTrGroup extends Component<HdsAdva
       const children = record[this.childrenKey];
 
       if (Array.isArray(children)) {
-        return children;
+        return children as Array<Record<string, unknown>>;
       }
     }
     return undefined;

packages/components/src/components/hds/advanced-table/index.ts

@@ -119,6 +119,7 @@ export default class HdsAdvancedTable extends Component<HdsAdvancedTableSignatur
 
   get columnWidths(): string[] | undefined {
     const { columns } = this.args;
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     const widths: string[] = new Array(columns.length);
     let hasCustomColumnWidth = false;
 

packages/components/src/components/hds/app-header/index.ts

@@ -61,9 +61,11 @@ export default class HdsAppHeader extends Component<HdsAppHeaderSignature> {
   }
 
   addEventListeners(): void {
+    // eslint-disable-next-line @typescript-eslint/unbound-method
     document.addEventListener('keydown', this.escapePress, true);
     this._desktopMQ.addEventListener(
       'change',
+      // eslint-disable-next-line @typescript-eslint/unbound-method
       this.updateDesktopVariable,
       true
     );
@@ -77,9 +79,11 @@ export default class HdsAppHeader extends Component<HdsAppHeaderSignature> {
   }
 
   removeEventListeners(): void {
+    // eslint-disable-next-line @typescript-eslint/unbound-method
     document.removeEventListener('keydown', this.escapePress, true);
     this._desktopMQ.removeEventListener(
       'change',
+      // eslint-disable-next-line @typescript-eslint/unbound-method
       this.updateDesktopVariable,
       true
     );

packages/components/src/components/hds/app-side-nav/index.ts

@@ -48,9 +48,11 @@ export default class HdsAppSideNav extends Component<HdsAppSideNavSignature> {
   }
 
   addEventListeners(): void {
+    // eslint-disable-next-line @typescript-eslint/unbound-method
     document.addEventListener('keydown', this.escapePress, true);
     this._desktopMQ.addEventListener(
       'change',
+      // eslint-disable-next-line @typescript-eslint/unbound-method
       this.updateDesktopVariable,
       true
     );
@@ -66,9 +68,11 @@ export default class HdsAppSideNav extends Component<HdsAppSideNavSignature> {
   }
 
   removeEventListeners(): void {
+    // eslint-disable-next-line @typescript-eslint/unbound-method
     document.removeEventListener('keydown', this.escapePress, true);
     this._desktopMQ.removeEventListener(
       'change',
+      // eslint-disable-next-line @typescript-eslint/unbound-method
       this.updateDesktopVariable,
       true
     );

packages/components/src/components/hds/app-side-nav/portal/target.ts

@@ -136,6 +136,7 @@ export default class HdsAppSideNavPortalTarget extends Component<HdsAppSideNavPo
       }
     );
 
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     anim.finished.then((): void => {
       // uncomment this if we need/want to scroll the element to the top
       // targetElement.scrollIntoView(true);

packages/components/src/components/hds/code-block/index.ts

@@ -90,6 +90,7 @@ export default class HdsCodeBlock extends Component<HdsCodeBlockSignature> {
     );
 
     if (Prism?.plugins?.['NormalizeWhitespace']) {
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
       return Prism.plugins['NormalizeWhitespace'].normalize(code);
     }
 
@@ -152,6 +153,7 @@ export default class HdsCodeBlock extends Component<HdsCodeBlockSignature> {
         if (language && grammar) {
           this._prismCode = htmlSafe(Prism.highlight(code, grammar, language));
         } else {
+          // eslint-disable-next-line @typescript-eslint/no-base-to-string
           this._prismCode = htmlSafe(Prism.util.encode(code).toString());
         }
 

packages/components/src/components/hds/flyout/index.ts

@@ -128,6 +128,7 @@ export default class HdsFlyout extends Component<HdsFlyoutSignature> {
     }
 
     // Register "onClose" callback function to be called when a native 'close' event is dispatched
+    // eslint-disable-next-line @typescript-eslint/unbound-method
     this._element.addEventListener('close', this.registerOnCloseCallback, true);
 
     // If the flyout dialog is not already open
@@ -141,6 +142,7 @@ export default class HdsFlyout extends Component<HdsFlyoutSignature> {
     if (this._element) {
       this._element.removeEventListener(
         'close',
+        // eslint-disable-next-line @typescript-eslint/unbound-method
         this.registerOnCloseCallback,
         true
       );
@@ -163,6 +165,7 @@ export default class HdsFlyout extends Component<HdsFlyoutSignature> {
   }
 
   @action
+  // eslint-disable-next-line @typescript-eslint/require-await
   async onDismiss(): Promise<void> {
     // allow ember test helpers to be aware of when the `close` event fires
     // when using `click` or other helpers from '@ember/test-helpers'

packages/components/src/components/hds/form/super-select/multiple/base.ts

@@ -47,6 +47,7 @@ export default class HdsFormSuperSelectMultipleBase extends Component<HdsFormSup
   }
 
   get selectedCount(): string {
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-member-access
     return this._powerSelectAPI?.selected?.length || '0';
   }
 

packages/components/src/components/hds/icon/index.ts

@@ -17,6 +17,7 @@ export const AVAILABLE_COLORS: string[] = Object.values(HdsIconColorValues);
 export interface HdsIconSignature {
   Args: {
     name: IconName;
+    // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
     color?: HdsIconColors | string | undefined;
     size?: HdsIconSizes;
     stretched?: boolean;

packages/components/src/components/hds/modal/index.ts

@@ -144,6 +144,7 @@ export default class HdsModal extends Component<HdsModalSignature> {
     }
 
     // Register "onClose" callback function to be called when a native 'close' event is dispatched
+    // eslint-disable-next-line @typescript-eslint/unbound-method
     this._element.addEventListener('close', this.registerOnCloseCallback, true);
 
     // If the modal dialog is not already open
@@ -157,6 +158,7 @@ export default class HdsModal extends Component<HdsModalSignature> {
     if (this._element) {
       this._element.removeEventListener(
         'close',
+        // eslint-disable-next-line @typescript-eslint/unbound-method
         this.registerOnCloseCallback,
         true
       );
@@ -179,6 +181,7 @@ export default class HdsModal extends Component<HdsModalSignature> {
   }
 
   @action
+  // eslint-disable-next-line @typescript-eslint/require-await
   async onDismiss(): Promise<void> {
     // allow ember test helpers to be aware of when the `close` event fires
     // when using `click` or other helpers from '@ember/test-helpers'

packages/components/src/components/hds/pagination/compact/index.ts

@@ -165,6 +165,7 @@ export default class HdsPaginationCompact extends Component<HdsPaginationCompact
     const { pageSizes = DEFAULT_PAGE_SIZES } = this.args;
 
     assert(
+      // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
       `pageSizes argument must be an array. Received: ${pageSizes}`,
       Array.isArray(pageSizes) === true && pageSizes.length > 0
     );

packages/components/src/components/hds/pagination/numbered/index.ts

@@ -278,6 +278,7 @@ export default class HdsPaginationNumbered extends Component<HdsPaginationNumber
 
     assert(
       // TODO: Add test for this
+      // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
       `pageSizes argument must be an array with at least one item. Received: ${pageSizes}`,
       Array.isArray(pageSizes) === true && pageSizes.length > 0
     );

packages/components/src/components/hds/popover-primitive/index.ts

@@ -85,18 +85,22 @@ export default class HdsPopoverPrimitive extends Component<HdsPopoverPrimitiveSi
         // @ts-expect-error: known issue with type of invocation
         registerEvent(this._containerElement, [
           'mouseenter',
+          // eslint-disable-next-line @typescript-eslint/unbound-method
           this.onMouseEnter,
         ]);
         // @ts-expect-error: known issue with type of invocation
         registerEvent(this._containerElement, [
           'mouseleave',
+          // eslint-disable-next-line @typescript-eslint/unbound-method
           this.onMouseLeave,
         ]);
         // @ts-expect-error: known issue with type of invocation
+        // eslint-disable-next-line @typescript-eslint/unbound-method
         registerEvent(this._containerElement, ['focusin', this.onFocusIn]);
       }
       // we always want the focusOut event
       // @ts-expect-error: known issue with type of invocation
+      // eslint-disable-next-line @typescript-eslint/unbound-method
       registerEvent(this._containerElement, ['focusout', this.onFocusOut]);
     }
   );
@@ -155,9 +159,11 @@ export default class HdsPopoverPrimitive extends Component<HdsPopoverPrimitiveSi
       // @ts-expect-error: known issue with type of invocation
       registerEvent(this._popoverElement, [
         'beforetoggle',
+        // eslint-disable-next-line @typescript-eslint/unbound-method
         this.onBeforeTogglePopover,
       ]);
       // @ts-expect-error: known issue with type of invocation
+      // eslint-disable-next-line @typescript-eslint/unbound-method
       registerEvent(this._popoverElement, ['toggle', this.onTogglePopover]);
 
       // we need to spread the argument because if it's set via `{{ hash … }}` Ember complains when we overwrite one of its values

packages/components/src/components/hds/side-nav/index.ts

@@ -98,7 +98,9 @@ export default class HdsSideNav extends Component<HdsSideNavSignature> {
   }
 
   addEventListeners(): void {
+    // eslint-disable-next-line @typescript-eslint/unbound-method
     document.addEventListener('keydown', this.escapePress, true);
+    // eslint-disable-next-line @typescript-eslint/unbound-method
     this.desktopMQ.addEventListener('change', this.updateDesktopVariable, true);
     // if not instantiated as minimized via arguments
     if (!this.args.isMinimized) {
@@ -112,9 +114,11 @@ export default class HdsSideNav extends Component<HdsSideNavSignature> {
   }
 
   removeEventListeners(): void {
+    // eslint-disable-next-line @typescript-eslint/unbound-method
     document.removeEventListener('keydown', this.escapePress, true);
     this.desktopMQ.removeEventListener(
       'change',
+      // eslint-disable-next-line @typescript-eslint/unbound-method
       this.updateDesktopVariable,
       true
     );

packages/components/src/components/hds/side-nav/portal/target.ts

@@ -136,6 +136,7 @@ export default class HdsSideNavPortalTarget extends Component<HdsSideNavPortalTa
       }
     );
 
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     anim.finished.then((): void => {
       // uncomment this if we need/want to scroll the element to the top
       // targetElement.scrollIntoView(true);

packages/components/src/components/hds/text/body.ts

@@ -64,6 +64,7 @@ export interface HdsTextBodySignature {
     tag?: HdsTextTags;
     weight?: HdsTextBodyWeight;
     align?: HdsTextAligns;
+    // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
     color?: string | HdsTextColors;
   };
   Element:

packages/components/src/components/hds/text/code.ts

@@ -58,6 +58,7 @@ export interface HdsTextCodeSignature {
     tag?: HdsTextTags;
     weight?: HdsTextCodeWeight;
     align?: HdsTextAligns;
+    // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
     color?: string | HdsTextColors;
   };
   Element:

packages/components/src/components/hds/text/display.ts

@@ -64,6 +64,7 @@ export interface HdsTextDisplaySignature {
     tag?: HdsTextTags;
     weight?: HdsTextDisplayWeight;
     align?: HdsTextAligns;
+    // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
     color?: string | HdsTextColors;
   };
   Element:

packages/components/src/components/hds/text/index.ts

@@ -27,6 +27,7 @@ export interface HdsTextSignature {
     tag?: HdsTextTags;
     weight?: HdsTextWeights;
     align?: HdsTextAligns;
+    // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
     color?: HdsTextColors | string | undefined;
     group: HdsTextGroups;
   };

packages/components/src/instance-initializers/load-sprite.ts

@@ -12,22 +12,27 @@ export async function initialize(
   }
 ) {
   if (
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
     config?.emberFlightIcons?.lazyEmbed &&
     // we use this flag to avoid loading the sprite multiple times
     appInstance.__flightIconsSpriteLoaded !== true
   ) {
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     const { default: svgSprite } = await import(
       // @ts-expect-error: missing types
       '@hashicorp/flight-icons/svg-sprite/svg-sprite-module'
     );
 
     // in test environments we can inject the sprite directly into the ember testing container
     // to avoid issues with tools like Percy that only consider content inside that element
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
     if (config.environment === 'test') {
       window.document
         ?.getElementById('ember-testing')
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         ?.insertAdjacentHTML('afterbegin', svgSprite);
     } else {
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
       window.document?.body?.insertAdjacentHTML('beforeend', svgSprite);
     }
 

packages/components/src/modifiers/hds-advanced-table-cell/dom-management.ts

@@ -5,7 +5,6 @@
 
 import { tabbable } from 'tabbable';
 
-import type { HdsAdvancedTableTdSignature } from '../../components/hds/advanced-table/td.ts';
 import type { HdsAdvancedTableThSignature } from '../../components/hds/advanced-table/th.ts';
 
 export const onFocusTrapDeactivate = (cell: HTMLDivElement) => {

packages/components/src/modifiers/hds-anchored-position.ts

@@ -267,6 +267,7 @@ export default modifier<HdsAnchoredPositionSignature>(
     const cleanupFloatingUI = autoUpdate(
       _anchorElement,
       _floatingElement,
+      // eslint-disable-next-line @typescript-eslint/no-misused-promises
       computeFloatingPosition
     );
 

packages/components/src/modifiers/hds-clipboard.ts

@@ -192,10 +192,12 @@ export default modifier<HdsClipboardModifierSignature>(
     };
 
     // add the "onClick" event listener to the element
+    // eslint-disable-next-line @typescript-eslint/no-misused-promises
     element.addEventListener('click', onClick);
 
     // this (teardown) function is run when the element is removed
     return (): void => {
+      // eslint-disable-next-line @typescript-eslint/no-misused-promises
       element.removeEventListener('click', onClick);
     };
   }

packages/components/src/modifiers/hds-code-editor.ts

@@ -175,13 +175,16 @@ export default class HdsCodeEditorModifier extends Modifier<HdsCodeEditorSignatu
     // if the editor does not exist, setup the editor
     else {
       // the intersection observer makes loading unreliable in tests
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
       if (config.environment === 'test') {
+        // eslint-disable-next-line @typescript-eslint/no-floating-promises
         this._setupTask.perform(element, positional, named);
       } else {
         this.observer = new IntersectionObserver(
           (entries) => {
             entries.forEach((entry) => {
               if (entry.isIntersecting && this.editor === undefined) {
+                // eslint-disable-next-line @typescript-eslint/no-floating-promises
                 this._setupTask.perform(element, positional, named);
               }
             });
@@ -315,6 +318,7 @@ export default class HdsCodeEditorModifier extends Modifier<HdsCodeEditorSignatu
         import('@codemirror/language'),
       ]);
 
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
       const languageExtension = await this._loadLanguageTask.perform(language);
 
       const handleUpdateExtension = EditorView.updateListener.of(

packages/components/src/services/hds-time.ts

@@ -230,6 +230,7 @@ export default class TimeService extends Service {
     this.#listeners.add(id);
     // @ts-expect-error - TS2339: Property 'perform' does not exist on type '() => TaskGenerator<string | undefined>'
     // note: we could potentially use taskFor via `ember-concurrency-ts` to avoid this exception
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-call
     this.start.perform();
     return (): void => {
       this.unregister(id);

packages/components/src/utils/hds-get-element-id.ts

@@ -8,13 +8,18 @@ import { guidFor } from '@ember/object/internals';
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 export function getElementId(element: any): string {
   // use @id arg, if provided
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
   if (element.args.id) {
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-member-access
     return element.args.id;
   }
 
   // otherwise, generate and memoize a guid
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
   if (!element._id) {
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
     element._id = guidFor(element);
   }
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-member-access
   return element._id;
 }