fixes after code reviews

Author: didoo

packages/components/addon/components/hds/alert/index.hbs

@@ -1,4 +1,4 @@
-<div class={{this.classNames}} role="alert" ...attributes>
+<div class={{this.classNames}} role="alert" aria-live="polite" ...attributes>
   {{#if this.icon}}
     <div class="hds-alert__icon">
       <FlightIcon @name={{this.icon}} @size={{this.iconSize}} @stretched={{true}} @isInlineBlock={{false}} />

packages/components/app/styles/components/alert.scss

@@ -99,7 +99,7 @@
   }
 
   > * + * {
-    margin-left: 16px;
+    margin-left: 8px;
   }
 }
 
@@ -182,14 +182,12 @@
     border-color: var(--token-color-border-strong); // notice: in the "neutral" color the "inline" has a slightly darker border color compared to the others to increase contrast (eg. could be used on a light gray background)
   }
 
-  &.hds-alert--type-compact {
-    // special override by design
-    .hds-alert__icon {
-      color: var(--token-color-foreground-faint);
-    }
+  // different color by design
+  .hds-alert__icon {
+    color: var(--token-color-foreground-faint);
   }
 
-  .hds-alert__icon, .hds-alert__title {
+  .hds-alert__title {
     color: var(--token-color-foreground-primary);
   }
 }

packages/components/tests/dummy/app/templates/components/alert.hbs

@@ -701,29 +701,29 @@
   <div class="dummy-alert-sample-grid dummy-alert-sample-grid--wide-content">
     <Hds::Alert
       @type="inline"
-      @color="critical"
+      @color="neutral"
       @title="Without the dismiss button (default)"
       @description="Lorem ipsum dolor sit amet, consectetur adipiscing elit."
     />
     <Hds::Alert
       @type="inline"
-      @color="critical"
+      @color="neutral"
       @title="With the dismiss button"
       @description="Lorem ipsum dolor sit amet, consectetur adipiscing elit."
       {{! TODO: understand if we can use a generic helper - see https://hashicorp.slack.com/archives/C11JCBJTW/p1648751235987409 }}
       @onDismiss={{this.noop}}
     />
     <Hds::Alert
       @type="inline"
-      @color="critical"
+      @color="neutral"
       @icon=""
       @title="With the dismiss button and no icon"
       @description="Lorem ipsum dolor sit amet, consectetur adipiscing elit."
       @onDismiss={{this.noop}}
     />
     <Hds::Alert
       @type="inline"
-      @color="critical"
+      @color="neutral"
       @description="With the dismiss button and no title"
       @onDismiss={{this.noop}}
     />