Skip to content

Commit 2997e6d

Browse files
shleewhitedchyun
andauthored
Apply suggestions from code review
Co-authored-by: Dylan Hyun <dylan.hyun@hashicorp.com>
1 parent b4e8875 commit 2997e6d

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

website/docs/components/table/advanced-table/partials/code/component-api.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ The Advanced Table component itself is where most of the options will be applied
7171
</C.Property>
7272
<C.Property @name="isSelectable" @type="boolean" @default="false">
7373
If set to `true`, creates a “multi-select” table which renders checkboxes in the table header and on the table rows enabling bulk interaction. Use in conjunction with `onSelectionChange` on the `Table` and `selectionKey` on each `Table::Tr`.<br><br>
74-
**Important**: AdvancedTable does **not** support having `isSelectable` true when there are nested rows.
74+
**Important**: Advanced Table does **not** support having `isSelectable` true when there are nested rows.
7575
</C.Property>
7676
<C.Property @name="onSelectionChange" @type="function">
7777
Use in conjunction with `isSelectable` to pass a callback function to know the selection state. Must be used in conjunction with setting a `selectionKey` on each `Table::Tr`.

website/docs/components/table/advanced-table/partials/code/how-to-use.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ It is not currently supported to have `@isStriped`, multi-select, or sortable co
116116

117117
!!!
118118

119-
Similar to the basic AdvancedTable, you can insert your own content into the `:body` block and the component will take care of looping over the `@model` provided for the parent and nested rows. The component adds the expand/collapse button to the `[B].Th` component in each row that has children.
119+
Similar to the basic Advanced Table, you can insert your own content into the `:body` block and the component will take care of looping over the `@model` provided for the parent and nested rows. The component adds the expand/collapse button to the `[B].Th` component in each row that has children.
120120

121121

122122
```handlebars
@@ -233,7 +233,7 @@ By default, the sort order is set to ascending. To indicate that the column defi
233233

234234
To implement a custom sort callback on a column:
235235

236-
1. add a custom function as the value for `sortingFunction` in the column hash,
236+
1. add a custom function as the value for `sortingFunction` in the column hash.
237237
2. include a custom `onSort` action in your Table invocation to track the sorting order and use it in the custom sorting function.
238238

239239
This is useful for cases where the key might not be A-Z or 0-9 sortable by default, e.g., status, and you’re otherwise unable to influence the shape of the data in the model.
@@ -298,7 +298,7 @@ customOnSort(_sortBy, sortOrder) {
298298

299299
### Density
300300

301-
To create a condensed or spacious Table, add `@density` to the Table’s invocation. Note that it only affects the Table body, not the Table header.
301+
To create a condensed or spacious Advanced Table, add `@density` to the Advanced Table’s invocation. Note that it only affects the table body, not the table header.
302302

303303
```handlebars
304304
<Hds::AdvancedTable
@@ -678,7 +678,7 @@ _Notice: only non-sortable headers can be visually hidden._
678678

679679
#### Internationalized column headers, overflow menu dropdown
680680

681-
Here’s an Advanced Table implementation that uses an array hash with localized strings for the column headers, indicates which columns should be sortable, and adds an overflow menu.
681+
Here’s an Advanced Table implementation that uses an array hash with localized strings for the column headers. It indicates which columns should be sortable, and adds an overflow menu.
682682

683683
```handlebars{data-execute=false}
684684
<Hds::AdvancedTable

0 commit comments

Comments
 (0)