Skip to content

Commit 2d017e6

Browse files
committed
Apply suggestions from code review
1 parent 2c117f0 commit 2d017e6

File tree

2 files changed

+3
-3
lines changed
  • packages/components/src/components/hds/dropdown
  • showcase/app/templates/components

2 files changed

+3
-3
lines changed

packages/components/src/components/hds/dropdown/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ export default class HdsDropdown extends Component<HdsDropdownSignature> {
143143
// context: https://github.com/hashicorp/design-system/pull/2309#discussion_r1706941892
144144
classes.push(`hds-dropdown__content--position-${this.listPosition}`);
145145

146-
// add a class based on the @width argument
146+
// add a class based on the @width or @matchToggleWidth arguments
147147
if (this.args.width || this.args.matchToggleWidth) {
148148
classes.push('hds-dropdown__content--fixed-width');
149149
}

showcase/app/templates/components/dropdown.hbs

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@
1414
<Shw::Grid @columns={{2}} as |SG|>
1515
{{#each @model.POSITIONS as |position|}}
1616
<SG.Item @label={{capitalize position}}>
17-
<div {{style padding="6em 12em"}} class="shw-outliner">
17+
<Shw::Outliner {{style padding="6em 12em"}}>
1818
<Hds::Dropdown @isOpen={{true}} @listPosition={{position}} as |D|>
1919
<D.ToggleButton @color="secondary" @text="Menu" />
2020
<D.Interactive @href="#">Create</D.Interactive>
2121
<D.Interactive @href="#">Edit</D.Interactive>
2222
</Hds::Dropdown>
23-
</div>
23+
</Shw::Outliner>
2424
</SG.Item>
2525
{{/each}}
2626
</Shw::Grid>

0 commit comments

Comments
 (0)