Apply suggestions from code review

alex-ju · didoo · web-flow · commit 41aa18f572fb · 2024-08-13T13:53:35.000+01:00
Co-authored-by: Cristiano Rastelli &lt;cristiano.rastelli@hashicorp.com&gt;
diff --git a/packages/components/src/components/hds/dropdown/types.ts b/packages/components/src/components/hds/dropdown/types.ts
@@ -15,6 +15,7 @@ export type HdsDropdownPositions = `${HdsDropdownPositionValues}`;
 
 // map Dropdown's `listPosition` values to PopoverPrimitive's `placement` values for backwards compatibility
 export const HdsDropdownPositionToPlacementValues: Record<
+  // Dropdown's `listPosition` values
   HdsDropdownPositionValues,
   FloatingUIOptions['placement']
 > = {
diff --git a/website/docs/components/dropdown/partials/version-history/4.10.0.md b/website/docs/components/dropdown/partials/version-history/4.10.0.md
@@ -4,4 +4,4 @@
 
 Added `@enableCollisionDetection` and `@isOpen` arguments
 
-Replaced the underlying `MenuPrimitive` with `PopoverPrimitive`
+Replaced the underlying `MenuPrimitive` with [`PopoverPrimitive`](/utilities/popover-primitive)
diff --git a/website/docs/utilities/menu-primitive/partials/code/how-to-use.md b/website/docs/utilities/menu-primitive/partials/code/how-to-use.md
@@ -1,6 +1,6 @@
 !!! Warning
 
-The `MenuPrimitive` component is deprecated and will be removed in a future major release. We recommend migrating to [PopoverPrimitive](/utilities/popover-primitive).
+The `MenuPrimitive` component is deprecated and will be removed in a future major release. We recommend migrating to [`PopoverPrimitive`](/utilities/popover-primitive).
 
 !!!
 
diff --git a/website/docs/utilities/menu-primitive/partials/version-history/4.10.0.md b/website/docs/utilities/menu-primitive/partials/version-history/4.10.0.md
@@ -6,4 +6,4 @@ In this version we replaced all `MenuPrimitive` instances with `PopoverPrimitive
 
 #### How to migrate
 
-Consider migrating the existing `MenuPrimitive` instances to [PopoverPrimitive](/utilities/popover-primitive).
+Consider migrating the existing `MenuPrimitive` instances to [`PopoverPrimitive`](/utilities/popover-primitive).

Original file line number	Diff line number	Diff line change
`@@ -4,4 +4,4 @@`
`4`	`4`
`5`	`5`	Added `@enableCollisionDetection` and `@isOpen` arguments
`6`	`6`
`7`		-Replaced the underlying `MenuPrimitive` with `PopoverPrimitive`
	`7`	+Replaced the underlying `MenuPrimitive` with [`PopoverPrimitive`](/utilities/popover-primitive)
Original file line number	Diff line number	Diff line change
@@ -6,4 +6,4 @@ In this version we replaced all `MenuPrimitive` instances with `PopoverPrimitive
`6`	`6`
`7`	`7`	`#### How to migrate`
`8`	`8`
`9`		-Consider migrating the existing `MenuPrimitive` instances to [PopoverPrimitive](/utilities/popover-primitive).
	`9`	+Consider migrating the existing `MenuPrimitive` instances to [`PopoverPrimitive`](/utilities/popover-primitive).