responding to pr feedback

Author: zamoore

packages/components/src/components/hds/code-editor/full-screen-button.hbs

@@ -4,7 +4,7 @@
   @isIconOnly={{true}}
   @color="secondary"
   @size="small"
-  @icon={{this.icon}}
+  @icon={{this.state}}
   @text="Toggle full screen view"
   {{on "click" @onToggleFullScreen}}
 />

packages/components/src/components/hds/code-editor/full-screen-button.ts

@@ -20,28 +20,16 @@ export default class HdsCodeEditorFullScreenButton extends Component<HdsCodeEdit
     return this.args.isFullScreen ? 'minimize' : 'maximize';
   }
 
-  get className() {
+  get className(): string {
     const classes = [
       'hds-code-editor__full-screen-button',
       'hds-code-editor__button',
     ];
 
-    const stateClass = {
-      minimize: 'hds-code-editor__full-screen-button--minimize',
-      maximize: 'hds-code-editor__full-screen-button--maximize',
-    }[this.state];
+    const stateClass = `hds-code-editor__full-screen-button--${this.state}`;
 
     classes.push(stateClass);
 
     return classes.join(' ');
   }
-
-  get icon(): HdsButtonSignature['Args']['icon'] {
-    const stateIcons = {
-      minimize: 'minimize',
-      maximize: 'maximize',
-    } as const;
-
-    return stateIcons[this.state];
-  }
 }

packages/components/src/components/hds/code-editor/index.ts

@@ -87,9 +87,9 @@ export default class HdsCodeEditor extends Component<HdsCodeEditorSignature> {
   }
 
   @action
-  onInput(newVal: string): void {
-    this._value = newVal;
-    this.args.onInput?.(newVal);
+  onInput(newValue: string): void {
+    this._value = newValue;
+    this.args.onInput?.(newValue);
   }
 
   @action

packages/components/src/modifiers/hds-code-editor.ts

@@ -31,7 +31,7 @@ export interface HdsCodeEditorSignature {
   };
 }
 
-async function defineStreamLangugage(streamParser: StreamParser<unknown>) {
+async function defineStreamLanguage(streamParser: StreamParser<unknown>) {
   const { StreamLanguage } = await import('@codemirror/language');
 
   return StreamLanguage.define(streamParser);
@@ -46,13 +46,13 @@ const LANGUAGES: Record<
   ruby: {
     load: async () => {
       const { ruby } = await import('@codemirror/legacy-modes/mode/ruby');
-      return defineStreamLangugage(ruby);
+      return defineStreamLanguage(ruby);
     },
   },
   shell: {
     load: async () => {
       const { shell } = await import('@codemirror/legacy-modes/mode/shell');
-      return defineStreamLangugage(shell);
+      return defineStreamLanguage(shell);
     },
   },
   go: {