working on linting

Author: zamoore

packages/components/src/modifiers/hds-code-editor.ts

@@ -8,8 +8,12 @@ import { assert, warn } from '@ember/debug';
 import { registerDestructor } from '@ember/destroyable';
 import { task } from 'ember-concurrency';
 import config from 'ember-get-config';
+<<<<<<< HEAD
 import { Compartment } from '@codemirror/state';
 import { EditorView } from '@codemirror/view';
+=======
+import { linter } from '@codemirror/lint';
+>>>>>>> d7925fb42 (working on linting)
 
 // hds-dark theme
 import hdsDarkTheme from './hds-code-editor/themes/hds-dark-theme.ts';
@@ -318,7 +322,7 @@ export default class HdsCodeEditorModifier extends Modifier<HdsCodeEditorSignatu
 
       let lintingExtensions: Extension[] = [];
 
-      if (isLintingEnabled && language === 'json') {
+      if (isLintingEnabled) {
         const [{ linter, lintGutter }, { syntaxTree }] = await Promise.all([
           import('@codemirror/lint'),
           import('@codemirror/language'),
@@ -362,7 +366,7 @@ export default class HdsCodeEditorModifier extends Modifier<HdsCodeEditorSignatu
       ];
 
       if (languageExtension !== undefined) {
-        extensions = [languageExtension, ...extensions];
+        extensions = [...extensions, languageExtension];
       }
 
       if (lintingExtensions.length !== 0) {

showcase/app/controllers/components/code-editor.js

@@ -17,6 +17,7 @@ export default class CodeEditorController extends Controller {
     {
       value: 'rego',
       label: 'Rego',
+      isLintingEnabled: true,
       code: `package example.test
 import data.users
 
@@ -36,6 +37,7 @@ deny { base64.decode(input.encoded) == "decoded" }
     {
       value: 'ruby',
       label: 'Ruby',
+      isLintingEnabled: true,
       code: `require 'date'
 
 file_name = 'example_file.txt'
@@ -51,6 +53,7 @@ end`,
     {
       value: 'shell',
       label: 'Shell',
+      isLintingEnabled: true,
       code: `DIR="example_directory"
 LOG_FILE="script.log"
 
@@ -64,6 +67,7 @@ fi`,
     {
       value: 'go',
       label: 'Go',
+      isLintingEnabled: true,
       code: `package main
 
 import "fmt"
@@ -76,6 +80,7 @@ func main() {
     {
       value: 'hcl',
       label: 'HCL',
+      isLintingEnabled: true,
       code: `variable "region" {
   type    = string
   default = "us-west-1"
@@ -84,6 +89,7 @@ func main() {
     {
       value: 'javascript',
       label: 'JavaScript',
+      isLintingEnabled: true,
       code: `const message = 'Hello, world!';
 
 function sayMessage() {
@@ -106,6 +112,7 @@ sayMessage();
     {
       value: 'sentinel',
       label: 'Sentinel',
+      isLintingEnabled: true,
       code: `param allowed_regions = ["us-east-1", "us-west-2"]
 
 main = rule { all tfplan.resources[*].instances as r { r.attributes.region in allowed_regions } }
@@ -114,13 +121,15 @@ main = rule { all tfplan.resources[*].instances as r { r.attributes.region in al
     {
       value: 'sql',
       label: 'SQL',
+      isLintingEnabled: true,
       code: `SELECT 'Hello, world!';
 SELECT 'Welcome to SQL!';
 SELECT 'Enjoy coding!';`,
     },
     {
       value: 'yaml',
       label: 'YAML',
+      isLintingEnabled: true,
       code: `app_config:
   name: ExampleApp
   version: 1.0.0