Skip to content

Commit 53fbdc8

Browse files
authored
Merge pull request #2484 from hashicorp/showcase-app-frame-update
Showcase - Small update to the showcase for `AppFrame`
2 parents 7c5ab12 + 74476f2 commit 53fbdc8

File tree

1 file changed

+12
-4
lines changed
  • showcase/app/templates/layouts/app-frame

1 file changed

+12
-4
lines changed

showcase/app/templates/layouts/app-frame/index.hbs

+12-4
Original file line numberDiff line numberDiff line change
@@ -165,9 +165,17 @@
165165
<Shw::Text::H3>Framed</Shw::Text::H3>
166166

167167
<Shw::Frame
168-
@id="demo-full-app-frame"
168+
@id="demo-full-app-frame-lt-480px"
169169
@src="/layouts/app-frame/frameless/demo-full-app-frame"
170-
@label="Full app-frame"
170+
@label="Full app-frame (height < 480px)"
171+
@height="400"
172+
/>
173+
174+
<Shw::Frame
175+
@id="demo-full-app-frame-gt-480px"
176+
@src="/layouts/app-frame/frameless/demo-full-app-frame"
177+
@label="Full app-frame (height > 480px)"
178+
@height="500"
171179
/>
172180

173181
<Shw::Frame
@@ -182,9 +190,9 @@
182190

183191
<Shw::Text::H2>Content</Shw::Text::H2>
184192

185-
{{!
193+
{{!
186194
Note: The below examples are commented out as they are redundant to the following "Framed" examples.
187-
However we still need to find a solution for adding visual regression tests for the framed examples.
195+
However we still need to find a solution for adding visual regression tests for the framed examples.
188196
(So we may decide to uncomment these examples to add them back to the visual regression tests depending.)
189197
}}
190198
{{!-- <Shw::Grid @columns={{1}} {{style gap="2rem"}} as |SG|>

0 commit comments

Comments
 (0)