Skip to content

Commit 65bc048

Browse files
author
shleewhite
committed
fix: delete thead, just make getter instead
1 parent 60dfd87 commit 65bc048

File tree

6 files changed

+20
-56
lines changed

6 files changed

+20
-56
lines changed

packages/components/src/components.ts

-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ export { default as HdsAdvancedTableThButtonTooltip } from './components/hds/adv
2323
export { default as HdsAdvancedTableThSelectable } from './components/hds/advanced-table/th-selectable.ts';
2424
export { default as HdsAdvancedTableThSort } from './components/hds/advanced-table/th-sort.ts';
2525
export { default as HdsAdvancedTableTr } from './components/hds/advanced-table/tr.ts';
26-
export { default as HdsAdvancedTableThead } from './components/hds/advanced-table/thead.ts';
2726
export { default as HdsAdvancedTableThButtonExpand } from './components/hds/advanced-table/th-button-expand.ts';
2827
export { default as HdsAdvancedTableExpandableTrGroup } from './components/hds/advanced-table/expandable-tr-group.ts';
2928
export * from './components/hds/advanced-table/types.ts';

packages/components/src/components/hds/advanced-table/index.hbs

+2-6
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,7 @@
2121
</div>
2222

2323
{{! Header }}
24-
<Hds::AdvancedTable::Thead
25-
@hasStickyHeader={{@hasStickyHeader}}
26-
@isStickyHeaderPinned={{this.isStickyHeaderPinned}}
27-
@isStickyColumnPinned={{this.isStickyColumnPinned}}
28-
>
24+
<div class={{this.theadClassNames}} role="rowgroup">
2925
<Hds::AdvancedTable::Tr
3026
@selectionScope="col"
3127
@onClickSortBySelected={{if @selectableColumnKey (fn this.setSortBy @selectableColumnKey)}}
@@ -64,7 +60,7 @@
6460
{{/if}}
6561
{{/each}}
6662
</Hds::AdvancedTable::Tr>
67-
</Hds::AdvancedTable::Thead>
63+
</div>
6864

6965
{{! Body }}
7066
<div class="hds-advanced-table__tbody" role="rowgroup">

packages/components/src/components/hds/advanced-table/index.ts

+18
Original file line numberDiff line numberDiff line change
@@ -297,6 +297,24 @@ export default class HdsAdvancedTable extends Component<HdsAdvancedTableSignatur
297297
return classes.join(' ');
298298
}
299299

300+
get theadClassNames(): string {
301+
const classes = ['hds-advanced-table__thead'];
302+
303+
if (this.args.hasStickyHeader) {
304+
classes.push('hds-advanced-table__thead--sticky');
305+
}
306+
307+
if (this.isStickyHeaderPinned) {
308+
classes.push('hds-advanced-table__thead--is-pinned');
309+
}
310+
311+
if (this.isStickyColumnPinned) {
312+
classes.push('hds-advanced-table__thead--column-is-pinned');
313+
}
314+
315+
return classes.join(' ');
316+
}
317+
300318
private _setUpContainer = modifier((element: HTMLDivElement) => {
301319
this._outerElement = element;
302320

packages/components/src/components/hds/advanced-table/thead.hbs

-7
This file was deleted.

packages/components/src/components/hds/advanced-table/thead.ts

-39
This file was deleted.

packages/components/src/template-registry.ts

-3
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import type HdsAdvancedTableThButtonTooltipComponent from './components/hds/adva
1616
import type HdsAdvancedTableThSortComponent from './components/hds/advanced-table/th-sort';
1717
import type HdsAdvancedTableThSelectableComponent from './components/hds/advanced-table/th-selectable';
1818
import type HdsAdvancedTableTrComponent from './components/hds/advanced-table/tr';
19-
import type HdsAdvancedTableThead from './components/hds/advanced-table/thead.ts';
2019
import type HdsAdvancedTableExpandableTrGroupComponent from './components/hds/advanced-table/expandable-tr-group.ts';
2120
import type HdsAlertComponent from './components/hds/alert';
2221
import type HdsAlertDescriptionComponent from './components/hds/alert/description';
@@ -256,8 +255,6 @@ export default interface HdsComponentsRegistry {
256255
'hds/advanced-table/th-selectable': typeof HdsAdvancedTableThSelectableComponent;
257256
'Hds::AdvancedTable::ExpandableTrGroup': typeof HdsAdvancedTableExpandableTrGroupComponent;
258257
'hds/advanced-table/expandable-tr-group': typeof HdsAdvancedTableExpandableTrGroupComponent;
259-
'Hds::AdvancedTable::Thead': typeof HdsAdvancedTableThead;
260-
'hds/advanced-table/thead': typeof HdsAdvancedTableThead;
261258

262259
// Alert
263260
'Hds::Alert': typeof HdsAlertComponent;

0 commit comments

Comments
 (0)