fix: untangling yarn mess

Author: aklkv

package.json

@@ -1,21 +1,22 @@
 {
   "name": "@hashicorp/design-system",
-  "private": true,
   "version": "0.0.0",
+  "private": true,
+  "scripts": {
+    "release-packages": "pnpm changeset publish",
+    "version-packages": "pnpm changeset version && pnpm install --mode update-lockfile && pnpm -F website generate-changelog-markdown-files"
+  },
   "devDependencies": {
     "@changesets/cli": "^2.27.11",
     "@changesets/get-github-info": "^0.6.0",
+    "@glint/core": "^1.5.1",
     "dotenv": "^16.4.7"
   },
-  "scripts": {
-    "release-packages": "pnpm changeset publish",
-    "version-packages": "pnpm changeset version && pnpm install --mode update-lockfile && pnpm -F website generate-changelog-markdown-files"
-  },
   "packageManager": "pnpm@10.0.0+sha512.b8fef5494bd3fe4cbd4edabd0745df2ee5be3e4b0b8b08fa643aa3e4c6702ccc0f00d68fa8a8c9858a735a0032485a44990ed2810526c875e416f001b17df12b",
   "pnpm": {
     "patchedDependencies": {
-      "@glint/environment-ember-loose": "patches/@glint__environment-ember-loose.patch",
-      "@embroider/core": "patches/@embroider__core.patch"
+      "@embroider/core": "patches/@embroider__core.patch",
+      "@glint/environment-ember-loose": "patches/@glint__environment-ember-loose.patch"
     }
   }
 }

packages/components/package.json

@@ -44,6 +44,7 @@
     "@ember/string": "^3.1.1",
     "@ember/test-waiters": "^3.1.0",
     "@embroider/addon-shim": "^1.9.0",
+    "@embroider/macros": "^1.16.10",
     "@floating-ui/dom": "^1.6.12",
     "@glimmer/component": "^1.1.2",
     "@glimmer/tracking": "^1.1.2",

packages/components/src/components/hds/alert/index.ts

@@ -19,6 +19,7 @@ import type { HdsAlertColors, HdsAlertTypes } from './types.ts';
 import type { HdsAlertTitleSignature } from './title.ts';
 import type { HdsAlertDescriptionSignature } from './description.ts';
 import type { HdsIconSignature } from '../icon';
+import type Owner from '@ember/owner';
 
 export const TYPES: string[] = Object.values(HdsAlertTypeValues);
 export const DEFAULT_COLOR = HdsAlertColorValues.Neutral;
@@ -65,7 +66,7 @@ export default class HdsAlert extends Component<HdsAlertSignature> {
   @tracked private _role?: string;
   @tracked private _ariaLabelledBy?: string;
 
-  constructor(owner: unknown, args: HdsAlertSignature['Args']) {
+  constructor(owner: Owner, args: HdsAlertSignature['Args']) {
     super(owner, args);
 
     assert(

packages/components/src/components/hds/app-footer/status-link.ts

@@ -5,14 +5,15 @@
 
 import Component from '@glimmer/component';
 import { htmlSafe } from '@ember/template';
-import type { SafeString } from '@ember/template/-private/handlebars';
 import { assert } from '@ember/debug';
 
+import type { SafeString } from '@ember/template';
 import type { HdsInteractiveSignature } from '../interactive/';
 import { HdsAppFooterStatusLinkStatusValues } from './types.ts';
 import type { HdsAppFooterStatusTypes } from './types.ts';
 import type { HdsAppFooterLinkSignature } from './link.ts';
 import type { HdsIconSignature } from '../icon';
+import type Owner from '@ember/owner';
 
 export const STATUSES = HdsAppFooterStatusLinkStatusValues;
 
@@ -28,7 +29,7 @@ export interface HdsAppFooterStatusLinkSignature {
 }
 
 export default class HdsAppFooterStatusLink extends Component<HdsAppFooterStatusLinkSignature> {
-  constructor(owner: unknown, args: HdsInteractiveSignature['Args']) {
+  constructor(owner: Owner, args: HdsInteractiveSignature['Args']) {
     super(owner, args);
 
     assert(

packages/components/src/components/hds/app-header/index.ts

@@ -8,6 +8,7 @@ import { action } from '@ember/object';
 import { guidFor } from '@ember/object/internals';
 import { tracked } from '@glimmer/tracking';
 import { registerDestructor } from '@ember/destroyable';
+import type Owner from '@ember/owner';
 
 export interface HdsAppHeaderSignature {
   Args: {
@@ -50,7 +51,7 @@ export default class HdsAppHeader extends Component<HdsAppHeaderSignature> {
       '--hds-app-desktop-breakpoint'
     );
 
-  constructor(owner: unknown, args: Record<string, never>) {
+  constructor(owner: Owner, args: Record<string, never>) {
     super(owner, args);
     this._desktopMQ = window.matchMedia(`(min-width: ${this._desktopMQVal})`);
     this.addEventListeners();

packages/components/src/components/hds/app-side-nav/index.ts

@@ -7,6 +7,7 @@ import Component from '@glimmer/component';
 import { tracked } from '@glimmer/tracking';
 import { action } from '@ember/object';
 import { registerDestructor } from '@ember/destroyable';
+import type Owner from '@ember/owner';
 
 export interface HdsAppSideNavSignature {
   Args: {
@@ -36,7 +37,7 @@ export default class HdsAppSideNav extends Component<HdsAppSideNavSignature> {
     document.documentElement
   ).getPropertyValue('--hds-app-desktop-breakpoint');
 
-  constructor(owner: unknown, args: HdsAppSideNavSignature['Args']) {
+  constructor(owner: Owner, args: HdsAppSideNavSignature['Args']) {
     super(owner, args);
     this._isMinimized = this.args.isMinimized ?? false; // sets the default state on 'desktop' viewports
     this._desktopMQ = window.matchMedia(`(min-width:${this._desktopMQVal})`);

packages/components/src/components/hds/app-side-nav/portal/target.ts

@@ -7,7 +7,6 @@ import Component from '@glimmer/component';
 import { inject as service } from '@ember/service';
 import { tracked } from '@glimmer/tracking';
 import { action } from '@ember/object';
-import { DEBUG } from '@glimmer/env';
 import { macroCondition, isTesting } from '@embroider/macros';
 
 import type { HdsAppSideNavPortalSignature } from './index';
@@ -152,7 +151,7 @@ export default class HdsAppSideNavPortalTarget extends Component<HdsAppSideNavPo
         }
       }
       // Notice: we don't add the styles by default because it writes a `style` attribute to the element and it causes an additional re-render
-      if (DEBUG) {
+      if (macroCondition(isTesting())) {
         // Check the visibility of the element before attempting to commitStyles.
         if (targetElement.offsetParent !== null) {
           anim.commitStyles();

packages/components/src/components/hds/breadcrumb/item.ts

@@ -6,7 +6,7 @@
 import Component from '@glimmer/component';
 import { htmlSafe } from '@ember/template';
 import { assert } from '@ember/debug';
-import type { SafeString } from '@ember/template/-private/handlebars';
+import type { SafeString } from '@ember/template';
 import type { HdsIconSignature } from '../icon';
 
 export interface HdsBreadcrumbItemSignature {

packages/components/src/components/hds/code-block/index.ts

@@ -13,7 +13,7 @@ import { guidFor } from '@ember/object/internals';
 
 import Prism from 'prismjs';
 
-import type { SafeString } from '@ember/template/-private/handlebars';
+import type { SafeString } from '@ember/template';
 import type { ComponentLike } from '@glint/template';
 
 import type { HdsCodeBlockTitleSignature } from './title';

packages/components/src/components/hds/code-editor/index.ts

@@ -9,12 +9,13 @@ import { action } from '@ember/object';
 import { modifier } from 'ember-modifier';
 
 import type { ComponentLike } from '@glint/template';
-import type { HdsCodeEditorSignature as HdsCodeEditorModifierSignature } from 'src/modifiers/hds-code-editor';
+import type { HdsCodeEditorSignature as HdsCodeEditorModifierSignature } from '../../../modifiers/hds-code-editor.ts';
 import type { HdsCodeEditorDescriptionSignature } from './description';
 import type { HdsCodeEditorTitleSignature } from './title';
 import type { HdsCodeEditorGenericSignature } from './generic';
 import type { EditorView } from '@codemirror/view';
 import { guidFor } from '@ember/object/internals';
+import type Owner from '@ember/owner';
 export interface HdsCodeEditorSignature {
   Args: {
     hasCopyButton?: boolean;
@@ -58,7 +59,7 @@ export default class HdsCodeEditor extends Component<HdsCodeEditorSignature> {
     };
   });
 
-  constructor(owner: unknown, args: HdsCodeEditorSignature['Args']) {
+  constructor(owner: Owner, args: HdsCodeEditorSignature['Args']) {
     super(owner, args);
 
     if (args.value) {

packages/components/src/components/hds/dropdown/toggle/icon.ts

@@ -13,6 +13,7 @@ import type { HdsIconSignature } from '../../icon';
 import type { HdsDropdownToggleIconSizes } from './types';
 import type { ModifierLike } from '@glint/template';
 import type { SetupPrimitiveToggleModifier } from '../../popover-primitive/index.ts';
+import type Owner from '@ember/owner';
 
 export const DEFAULT_SIZE = HdsDropdownToggleIconSizeValues.Medium;
 export const SIZES: string[] = Object.values(HdsDropdownToggleIconSizeValues);
@@ -33,7 +34,7 @@ export interface HdsDropdownToggleIconSignature {
 export default class HdsDropdownToggleIcon extends Component<HdsDropdownToggleIconSignature> {
   @tracked private _hasImage = true;
 
-  constructor(owner: unknown, args: HdsDropdownToggleIconSignature['Args']) {
+  constructor(owner: Owner, args: HdsDropdownToggleIconSignature['Args']) {
     super(owner, args);
     if (!(this.args.icon || this.args.imageSrc)) {
       assert(

packages/components/src/components/hds/flyout/body.ts

@@ -6,6 +6,8 @@
 import Component from '@glimmer/component';
 import { deprecate } from '@ember/debug';
 
+import type Owner from '@ember/owner';
+
 export interface HdsFlyoutBodySignature {
   // when component has no args, but constructor still needs to be defined, use `never`
   // see: https://github.com/hashicorp/design-system/pull/2511/files/f2146e5243d0431892a62d2fbf2889f1cbd3e525#r1815255004
@@ -17,7 +19,7 @@ export interface HdsFlyoutBodySignature {
 }
 
 export default class HdsFlyoutBody extends Component<HdsFlyoutBodySignature> {
-  constructor(owner: unknown, args: HdsFlyoutBodySignature['Args']) {
+  constructor(owner: Owner, args: HdsFlyoutBodySignature['Args']) {
     super(owner, args);
 
     deprecate(
@@ -30,6 +32,7 @@ export default class HdsFlyoutBody extends Component<HdsFlyoutBodySignature> {
         for: '@hashicorp/design-system-components',
         since: {
           enabled: '4.6.0',
+          available: '4.6.0',
         },
       }
     );

packages/components/src/components/hds/flyout/description.ts

@@ -6,6 +6,7 @@
 import Component from '@glimmer/component';
 import { deprecate } from '@ember/debug';
 import type { HdsTextBodySignature } from '../text/body';
+import type Owner from '@ember/owner';
 
 export interface HdsFlyoutDescriptionSignature {
   Args: never;
@@ -16,7 +17,7 @@ export interface HdsFlyoutDescriptionSignature {
 }
 
 export default class HdsFlyoutDescription extends Component<HdsFlyoutDescriptionSignature> {
-  constructor(owner: unknown, args: HdsFlyoutDescriptionSignature['Args']) {
+  constructor(owner: Owner, args: HdsFlyoutDescriptionSignature['Args']) {
     super(owner, args);
 
     deprecate(
@@ -28,6 +29,7 @@ export default class HdsFlyoutDescription extends Component<HdsFlyoutDescription
         url: 'https://helios.hashicorp.design/components/flyout?tab=version%20history#460',
         for: '@hashicorp/design-system-components',
         since: {
+          available: '4.5.0',
           enabled: '4.6.0',
         },
       }

packages/components/src/components/hds/flyout/footer.ts

@@ -5,6 +5,7 @@
 
 import Component from '@glimmer/component';
 import { deprecate } from '@ember/debug';
+import type Owner from '@ember/owner';
 
 export interface HdsFlyoutFooterSignature {
   Args: {
@@ -17,7 +18,7 @@ export interface HdsFlyoutFooterSignature {
 }
 
 export default class HdsFlyoutFooter extends Component<HdsFlyoutFooterSignature> {
-  constructor(owner: unknown, args: HdsFlyoutFooterSignature['Args']) {
+  constructor(owner: Owner, args: HdsFlyoutFooterSignature['Args']) {
     super(owner, args);
 
     deprecate(
@@ -30,6 +31,7 @@ export default class HdsFlyoutFooter extends Component<HdsFlyoutFooterSignature>
         for: '@hashicorp/design-system-components',
         since: {
           enabled: '4.6.0',
+          available: '4.6.0',
         },
       }
     );

packages/components/src/components/hds/flyout/header.ts

@@ -6,6 +6,7 @@
 import Component from '@glimmer/component';
 import { deprecate } from '@ember/debug';
 import type { HdsIconSignature } from '../icon';
+import type Owner from '@ember/owner';
 
 export interface HdsFlyoutHeaderSignature {
   Args: {
@@ -21,7 +22,7 @@ export interface HdsFlyoutHeaderSignature {
 }
 
 export default class HdsFlyoutHeader extends Component<HdsFlyoutHeaderSignature> {
-  constructor(owner: unknown, args: HdsFlyoutHeaderSignature['Args']) {
+  constructor(owner: Owner, args: HdsFlyoutHeaderSignature['Args']) {
     super(owner, args);
 
     deprecate(
@@ -34,6 +35,7 @@ export default class HdsFlyoutHeader extends Component<HdsFlyoutHeaderSignature>
         for: '@hashicorp/design-system-components',
         since: {
           enabled: '4.6.0',
+          available: '4.6.0',
         },
       }
     );

packages/components/src/components/hds/form/masked-input/base.ts

@@ -9,6 +9,7 @@ import { getElementId } from '../../../../utils/hds-get-element-id.ts';
 import type { HdsCopyButtonSignature } from '../../copy/button/index.ts';
 import type { HdsFormVisibilityToggleSignature } from '../visibility-toggle/index.ts';
 import { tracked } from '@glimmer/tracking';
+import type Owner from '@ember/owner';
 
 export interface HdsFormMaskedInputBaseSignature {
   Args: {
@@ -30,7 +31,7 @@ export interface HdsFormMaskedInputBaseSignature {
 export default class HdsFormMaskedInputBase extends Component<HdsFormMaskedInputBaseSignature> {
   @tracked isContentMasked;
 
-  constructor(owner: unknown, args: HdsFormMaskedInputBaseSignature['Args']) {
+  constructor(owner: Owner, args: HdsFormMaskedInputBaseSignature['Args']) {
     super(owner, args);
     this.isContentMasked = this.args.isContentMasked ?? true;
   }

packages/components/src/components/hds/form/text-input/field.ts

@@ -15,6 +15,7 @@ import type { HdsFormHelperTextSignature } from '../helper-text';
 import type { HdsFormLabelSignature } from '../label';
 import type { HdsFormVisibilityToggleSignature } from '../visibility-toggle';
 import HdsFormCharacterCountComponent from '../character-count/index.ts';
+import type Owner from '@ember/owner';
 
 export interface HdsFormTextInputFieldSignature {
   Args: Omit<HdsFormFieldSignature['Args'], 'contextualClass' | 'layout'> &
@@ -42,7 +43,7 @@ export default class HdsFormTextInputField extends Component<HdsFormTextInputFie
   @tracked private _isPasswordMasked = true;
   @tracked type;
 
-  constructor(owner: unknown, args: HdsFormTextInputFieldSignature['Args']) {
+  constructor(owner: Owner, args: HdsFormTextInputFieldSignature['Args']) {
     super(owner, args);
     this.type = this.args.type ?? 'text';
   }

packages/components/src/components/hds/icon/index.ts

@@ -10,6 +10,7 @@ import { iconNames } from '@hashicorp/flight-icons/svg';
 import { HdsIconSizeValues, HdsIconColorValues } from './types.ts';
 import type { HdsIconSizes, HdsIconColors } from './types';
 import type { IconName } from '@hashicorp/flight-icons/svg';
+import type Owner from '@ember/owner';
 
 export const AVAILABLE_COLORS: string[] = Object.values(HdsIconColorValues);
 
@@ -29,7 +30,7 @@ export default class HdsIcon extends Component<HdsIconSignature> {
   private _iconId = 'icon-' + guidFor(this);
   private _titleId = 'title-' + guidFor(this);
 
-  constructor(owner: unknown, args: HdsIconSignature['Args']) {
+  constructor(owner: Owner, args: HdsIconSignature['Args']) {
     super(owner, args);
 
     if (!this.args.name) {

packages/components/src/components/hds/link/inline.ts

@@ -10,6 +10,7 @@ import { HdsLinkColorValues, HdsLinkIconPositionValues } from './types.ts';
 import type { HdsInteractiveSignature } from '../interactive/';
 import type { HdsLinkColors, HdsLinkIconPositions } from './types.ts';
 import type { HdsIconSignature } from '../icon';
+import type Owner from '@ember/owner';
 
 export const DEFAULT_ICONPOSITION = HdsLinkIconPositionValues.Trailing;
 export const DEFAULT_COLOR = HdsLinkColorValues.Primary;
@@ -29,7 +30,7 @@ export interface HdsLinkInlineSignature {
 }
 
 export default class HdsLinkInline extends Component<HdsLinkInlineSignature> {
-  constructor(owner: unknown, args: HdsLinkInlineSignature['Args']) {
+  constructor(owner: Owner, args: HdsLinkInlineSignature['Args']) {
     super(owner, args);
     if (!(this.args.href || this.args.route)) {
       assert('@href or @route must be defined for <Hds::Link::Inline>');

packages/components/src/components/hds/link/standalone.ts

@@ -18,6 +18,7 @@ import type {
   HdsLinkStandaloneSizes,
 } from './types.ts';
 import type { HdsIconSignature } from '../icon';
+import type Owner from '@ember/owner';
 
 export interface HdsLinkStandaloneSignature {
   Args: HdsInteractiveSignature['Args'] & {
@@ -38,7 +39,7 @@ export const COLORS: string[] = Object.values(HdsLinkColorValues);
 export const SIZES: string[] = Object.values(HdsLinkStandaloneSizeValues);
 
 export default class HdsLinkStandalone extends Component<HdsLinkStandaloneSignature> {
-  constructor(owner: unknown, args: HdsLinkStandaloneSignature['Args']) {
+  constructor(owner: Owner, args: HdsLinkStandaloneSignature['Args']) {
     super(owner, args);
     if (!(this.args.href || this.args.route)) {
       assert('@href or @route must be defined for <Hds::Link::Standalone>');