Improve no icon logic with test

Author: amyrlam

packages/components/addon/components/hds/alert/index.hbs

@@ -1,10 +1,12 @@
 <div class={{this.classNames}} ...attributes role="alert">
   {{! template-lint-disable simple-unless}}
-  {{#unless (eq this.icon "")}}
+  {{!-- {{#unless (eq this.icon "")}} --}}
+  {{#if this.icon}}
     <div class="hds-alert__icon">
       <FlightIcon @name={{this.icon}} @size="24" @isInlineBlock={{false}} />
     </div>
-  {{/unless}}
+  {{/if}}
+  {{!-- {{/unless}} --}}
 
   <div class="hds-alert__content">
     <div class="hds-alert__text">

packages/components/addon/components/hds/alert/index.js

@@ -76,10 +76,15 @@ export default class HdsAlertIndexComponent extends Component {
   get icon() {
     let { icon } = this.args;
 
-    if (icon === '') {
-      return icon;
+    // If `icon` isn't passed, use the pre-defined one from `color`
+    if (icon === undefined) {
+      return MAPPING_COLORS_TO_ICONS[this.color];
+      // If `icon` is set explicitly to false, user doesn't want any icon in the alert
+    } else if (icon === false) {
+      return false;
     } else {
-      return icon || MAPPING_COLORS_TO_ICONS[this.color];
+      // If a name for `icon` is passed, set FlightIcon to that name
+      return icon;
     }
   }
 

packages/components/tests/integration/components/hds/alert/index-test.js

@@ -35,12 +35,20 @@ module('Integration | Component | hds/alert/index', function (hooks) {
       .exists();
   });
 
+  test('Alert should display no icon, when empty string is passed', async function (assert) {
+    await render(hbs`<Hds::Alert @title="yo" @icon="" />`);
+    assert
+      .dom(
+        this.element.querySelector('.flight-icon.flight-icon-clipboard-copy')
+      )
+      .doesNotExist();
+  });
+
   // ASSERTIONS
 
   test('Throw an assertion if @title and @description is missing/has no value', async function (assert) {
     const errorMessage =
       'you need to pass @title or @description to the "Hds::Alert" component';
-    // TODO: Debug
     assert.expect(2);
 
     setupOnerror(function (error) {