Ensure compatible types

Ensures type safety without the need for inline type assertions

Author: alex-ju

packages/components/src/components/hds/app-footer/status-link.ts

@@ -65,8 +65,7 @@ export default class HdsAppFooterStatusLinkComponent extends Component<HdsAppFoo
    */
   get statusIcon() {
     if (this.status && !this.args.statusIcon) {
-      return STATUSES[this.status]
-        ?.iconName as FlightIconSignature['Args']['name'];
+      return STATUSES[this.status]?.iconName;
     }
     return this.args.statusIcon;
   }

packages/components/src/components/hds/app-footer/types.ts

@@ -2,6 +2,7 @@
  * Copyright (c) HashiCorp, Inc.
  * SPDX-License-Identifier: MPL-2.0
  */
+import type { FlightIconSignature } from '@hashicorp/ember-flight-icons/components/flight-icon';
 
 export enum HdsAppFooterStatusValues {
   Operational = 'operational',
@@ -16,7 +17,7 @@ export const HdsAppFooterStatusLinkStatusValues: Record<
   HdsAppFooterStatusValues,
   {
     text: string;
-    iconName: string;
+    iconName: FlightIconSignature['Args']['name'];
   }
 > = {
   [HdsAppFooterStatusValues.Operational]: {

packages/components/src/components/hds/stepper/task/indicator.ts

@@ -11,7 +11,6 @@ import {
   HdsStepperStatusToIconsValues,
 } from '../types.ts';
 import type { HdsStepperStatuses } from '../types.ts';
-import type { FlightIconSignature } from '@hashicorp/ember-flight-icons/components/flight-icon';
 
 export const DEFAULT_STATUS = HdsStepperStatusesValues.Incomplete;
 export const STATUSES: string[] = Object.values(HdsStepperStatusesValues);
@@ -62,9 +61,7 @@ export default class HdsStepperTaskIndicatorComponent extends Component<HdsStepp
    */
 
   get iconName() {
-    return MAPPING_STATUS_TO_ICONS[
-      this.status
-    ] as FlightIconSignature['Args']['name'];
+    return MAPPING_STATUS_TO_ICONS[this.status];
   }
 
   /**

packages/components/src/components/hds/stepper/types.ts

@@ -2,6 +2,7 @@
  * Copyright (c) HashiCorp, Inc.
  * SPDX-License-Identifier: MPL-2.0
  */
+import type { FlightIconSignature } from '@hashicorp/ember-flight-icons/components/flight-icon';
 
 export enum HdsStepperStatusesValues {
   Incomplete = 'incomplete',
@@ -14,7 +15,7 @@ export type HdsStepperStatuses = `${HdsStepperStatusesValues}`;
 
 export const HdsStepperStatusToIconsValues: Record<
   HdsStepperStatusesValues,
-  string
+  FlightIconSignature['Args']['name']
 > = {
   [HdsStepperStatusesValues.Incomplete]: 'circle',
   [HdsStepperStatusesValues.Progress]: 'circle-half',