fix(components): 💅 lint:types

aklkv · aklkv · commit 9efb9bd70e54 · 2025-03-14T02:06:19.000-07:00
diff --git a/packages/components/src/components/hds/breadcrumb/item.hbs b/packages/components/src/components/hds/breadcrumb/item.hbs
@@ -14,7 +14,6 @@
     </div>
   {{else}}
     {{#if @isRouteExternal}}
-      {{! @glint-expect-error: FIXME: pnpm migration }}
       <LinkToExternal
         class="hds-breadcrumb__link"
         @current-when={{@current-when}}
diff --git a/packages/components/src/components/hds/flyout/index.ts b/packages/components/src/components/hds/flyout/index.ts
@@ -61,7 +61,7 @@ export default class HdsFlyout extends Component<HdsFlyoutSignature> {
   @tracked private _isOpen = false;
   // TODO: make this property private; currently blocked by our consumers relying on it despite not being part of the public API: https://github.com/hashicorp/cloud-ui/blob/main/engines/waypoint/addon/components/preview-pane.ts#L15
   // private _element!: HTMLDialogElement;
-  element!: HTMLDialogElement;
+  _element!: HTMLDialogElement;
   private _body!: HTMLElement;
   private _bodyInitialOverflowValue = '';
 
@@ -118,7 +118,7 @@ export default class HdsFlyout extends Component<HdsFlyoutSignature> {
   @action
   didInsert(element: HTMLDialogElement): void {
     // Store references of `<dialog>` and `<body>` elements
-    this.element = element;
+    this._element = element;
     this._body = document.body;
 
     if (this._body) {
@@ -128,18 +128,18 @@ export default class HdsFlyout extends Component<HdsFlyoutSignature> {
     }
 
     // Register "onClose" callback function to be called when a native 'close' event is dispatched
-    this.element.addEventListener('close', this.registerOnCloseCallback, true);
+    this._element.addEventListener('close', this.registerOnCloseCallback, true);
 
     // If the flyout dialog is not already open
-    if (!this.element.open) {
+    if (!this._element.open) {
       this.open();
     }
   }
 
   @action
   willDestroyNode(): void {
-    if (this.element) {
-      this.element.removeEventListener(
+    if (this._element) {
+      this._element.removeEventListener(
         'close',
         this.registerOnCloseCallback,
         true
@@ -150,7 +150,7 @@ export default class HdsFlyout extends Component<HdsFlyoutSignature> {
   @action
   open(): void {
     // Make flyout dialog visible using the native `showModal` method
-    this.element.showModal();
+    this._element.showModal();
     this._isOpen = true;
 
     // Prevent page from scrolling when the dialog is open
@@ -167,17 +167,17 @@ export default class HdsFlyout extends Component<HdsFlyoutSignature> {
     // allow ember test helpers to be aware of when the `close` event fires
     // when using `click` or other helpers from '@ember/test-helpers'
     // Notice: this code will get stripped out in production builds (DEBUG evaluates to `true` in dev/test builds, but `false` in prod builds)
-    if (this.element.open) {
+    if (this._element.open) {
       const token = waiter.beginAsync();
       const listener = () => {
         waiter.endAsync(token);
-        this.element.removeEventListener('close', listener);
+        this._element.removeEventListener('close', listener);
       };
-      this.element.addEventListener('close', listener);
+      this._element.addEventListener('close', listener);
     }
 
     // Make flyout dialog invisible using the native `close` method
-    this.element.close();
+    this._element.close();
 
     // Reset page `overflow` property
     if (this._body) {
diff --git a/packages/components/src/components/hds/interactive/index.hbs b/packages/components/src/components/hds/interactive/index.hbs
@@ -3,7 +3,6 @@
 {{! NOTICE: we can't support the direct use of the "href" HTML attribute via ...attributes in the <a> elements, because we need to rely on the "@href" Ember argument to differentiate between different types of generated output }}
 {{~#if @route~}}
   {{~#if this.isRouteExternal~}}
-    {{! @glint-expect-error: FIXME: pnpm migration }}
     <LinkToExternal
       @current-when={{@current-when}}
       @models={{hds-link-to-models @model @models}}
diff --git a/packages/components/src/components/hds/menu-primitive/index.ts b/packages/components/src/components/hds/menu-primitive/index.ts
@@ -36,7 +36,7 @@ export interface MenuPrimitiveSignature {
 export default class MenuPrimitive extends Component<MenuPrimitiveSignature> {
   @tracked isOpen: boolean | undefined; // notice: if in the future we need to add a "@isOpen" prop to control the status from outside (eg to have the MenuPrimitive opened on render) just add  "this.args.isOpen" here to initalize the variable
   @tracked toggleRef: HTMLElement | undefined;
-  @tracked element!: HTMLElement;
+  @tracked _element!: HTMLElement;
 
   constructor(owner: Owner, args: MenuPrimitiveSignature['Args']) {
     super(owner, args);
@@ -59,7 +59,7 @@ export default class MenuPrimitive extends Component<MenuPrimitiveSignature> {
 
   @action
   didInsert(element: HTMLElement): void {
-    this.element = element;
+    this._element = element;
   }
 
   @action
