Skip to content

Commit c0cd637

Browse files
committed
small fixes per PR reviews/suggestions
1 parent e0a7906 commit c0cd637

File tree

4 files changed

+6
-8
lines changed

4 files changed

+6
-8
lines changed

packages/components/src/components/hds/layout/flex/index.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
}}
55
{{!
66
Dynamically generating an HTML tag in Ember creates a dynamic component class (with the corresponding tagName), while rendering
7-
a plain HTML elements requires less computing cycles for Ember (you will notice it doesn't add the `ember-view` class to it).
7+
a plain HTML element requires less computing cycles for Ember (you will notice it doesn't add the `ember-view` class to it).
88
}}
99
{{#if (eq this.componentTag "div")}}
1010
<div class={{this.classNames}} ...attributes>{{yield (hash Item=(component "hds/layout/flex/item"))}}</div>

packages/components/src/components/hds/layout/flex/item.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
}}
55
{{!
66
Dynamically generating an HTML tag in Ember creates a dynamic component class (with the corresponding tagName), while rendering
7-
a plain HTML elements requires less computing cycles for Ember (you will notice it doesn't add the `ember-view` class to it).
7+
a plain HTML element requires less computing cycles for Ember (you will notice it doesn't add the `ember-view` class to it).
88
}}
99
{{#if (eq this.componentTag "div")}}
1010
<div class={{this.classNames}} {{style this.inlineStyles}} ...attributes>{{yield}}</div>

packages/components/src/components/hds/layout/flex/types.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ export enum HdsLayoutFlexGapValues {
3535
'Eight' = '8',
3636
'Twelve' = '12',
3737
'Sixteen' = '16',
38-
'Twentyfour' = '24',
39-
'Thirtytwo' = '32',
40-
'Fortyeight' = '48',
38+
'TwentyFour' = '24',
39+
'ThirtyTwo' = '32',
40+
'FortyEight' = '48',
4141
}
4242

4343
export type HdsLayoutFlexGaps = `${HdsLayoutFlexGapValues}`;

packages/components/src/styles/components/layout/flex.scss

+1-3
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
// Note: The gap style is defined here to avoid setting it repeatedly for the gap size variants defined below.
1414
// For the gap size variants, we override the value of the gap custom properties to set the desired sizes.
15-
// These variables can be used by the consumers as escape hatch if they need to set non-standard gap values (but adds a bit of friction to it)
15+
// These variables can be used by the consumers as an escape hatch if they need to set non-standard gap values (but adds a bit of friction to it)
1616
gap:
1717
var(--hds-layout-flex-row-gap, 0)
1818
var(--hds-layout-flex-column-gap, 0);
@@ -90,7 +90,6 @@
9090

9191
// gap
9292

93-
// set just row gap size
9493
.hds-layout-flex--row-gap-4 { --hds-layout-flex-row-gap: 4px; }
9594
.hds-layout-flex--row-gap-8 { --hds-layout-flex-row-gap: 8px; }
9695
.hds-layout-flex--row-gap-12 { --hds-layout-flex-row-gap: 12px; }
@@ -99,7 +98,6 @@
9998
.hds-layout-flex--row-gap-32 { --hds-layout-flex-row-gap: 32px; }
10099
.hds-layout-flex--row-gap-48 { --hds-layout-flex-row-gap: 48px; }
101100

102-
// set just column gap size
103101
.hds-layout-flex--column-gap-4 { --hds-layout-flex-column-gap: 4px; }
104102
.hds-layout-flex--column-gap-8 { --hds-layout-flex-column-gap: 8px; }
105103
.hds-layout-flex--column-gap-12 { --hds-layout-flex-column-gap: 12px; }

0 commit comments

Comments
 (0)