Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Alert" component - Actions as named blocks #130

Merged
merged 5 commits into from
Mar 29, 2022

Conversation

didoo
Copy link
Contributor

@didoo didoo commented Mar 28, 2022

📌 Summary

As a follow-up of #104 this PR brings in only the relevant changes to the Alert component.

🛠️ Detailed description

In this PR I have:

  • added the actions for the Alert component as named block with yielded components
  • added showcase for actions
  • fixed regex used in the “DummyPlaceholder” (extra)

Notice: the documentation about the actions (API, how to use, etc) will be done in final part of the component implementation, when things are more stable.


👀 How to review

👉 Review by files changed (take in account the code has already been reviewed in #104)

Reviewer's checklist:

  • +1 Percy if applicable
  • Confirm that PR has a changelog update via Changesets if needed

💬 Please consider using conventional comments when reviewing this PR.

Sorry, something went wrong.

@didoo didoo requested a review from amyrlam March 28, 2022 21:25
@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2022

⚠️ No Changeset found

Latest commit: 6f1e2cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 28, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

hds-flight-website – ./

🔍 Inspect: https://vercel.com/hashicorp/hds-flight-website/3VYunb7FGnZ4H2tUjkY8f5mjWCRb
✅ Preview: https://hds-flight-website-git-alert-actions-as-named-block-hashicorp.vercel.app

hds-components – ./

🔍 Inspect: https://vercel.com/hashicorp/hds-components/y544LSsraU7iUBspXFK4sPArE1wS
✅ Preview: https://hds-components-git-alert-actions-as-named-block-hashicorp.vercel.app

@amyrlam amyrlam changed the base branch from amy/alert-overall-branch to amy/alert-page March 29, 2022 01:04
@amyrlam amyrlam mentioned this pull request Mar 29, 2022
1 task
@amyrlam amyrlam force-pushed the alert-actions-as-named-block branch from 56d8fc5 to 6f1e2cc Compare March 29, 2022 01:18
@vercel vercel bot temporarily deployed to Preview – hds-components March 29, 2022 01:18 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website March 29, 2022 01:18 Inactive
Copy link
Contributor

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

went ahead and rebased, merging into #124, will @ when #124 is done

@amyrlam amyrlam merged commit 5a35035 into amy/alert-page Mar 29, 2022
@amyrlam amyrlam deleted the alert-actions-as-named-block branch March 29, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants