Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website: create new content section #2572

Merged
merged 11 commits into from
Dec 10, 2024
Merged

Website: create new content section #2572

merged 11 commits into from
Dec 10, 2024

Conversation

shleewhite
Copy link
Contributor

@shleewhite shleewhite commented Nov 19, 2024 •
edited
Loading

📌 Summary

If merged, this PR would

  • update the main website navigation
    • reorder the items in the top nav and the sidebar
    • add new content section
    • change the design for search, support items
    • add content section to sidebar
  • create stub pages for voice and tone and writing for ui copy

📸 Screenshots

Screenshot 2024-12-05 at 5 07 11 PM

🔗 External links

Jira ticket: HDS-4159
Jira ticket: HDS-4158
Figma file: https://www.figma.com/design/ZlIlup8HxCOlQLXRwv56In/HDS-Content-Guidelines?node-id=119-3584&node-type=canvas&t=cyilBmJA92W2EKn5-0

💬 Please consider using conventional comments when reviewing this PR.

@vercel Vercel
Copy link

vercel bot commented Nov 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Dec 5, 2024 9:25pm
hds-website ✅ Ready (Inspect) Visit Preview Dec 5, 2024 9:25pm

@hashibot-hds hashibot-hds added the docs-website Content updates to the documentation website label Nov 19, 2024
didoo
didoo reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of minor comments.

@dchyun
Copy link
Contributor

dchyun commented Nov 21, 2024

Small thing, but in the mobile menu, looks like the spacing between the two icons, and between the menu and the edge of the screen are a bit tighter in the figma.

Figma

Screenshot 2024-11-21 at 10 28 05 AM

Current UI

Screenshot 2024-11-21 at 10 28 15 AM

shleewhite
shleewhite commented Nov 21, 2024
View reviewed changes
website/app/styles/pages/application/header.scss
@@ -139,75 +135,35 @@
}
}

.doc-page-header__nav-item-generic {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These styles were only affecting the support icon link and the github link and the only thing they did were add display block and make the focus ring look way thicker than the other nav items' focus states.

Screenshot 2024-11-21 at 11 17 36 AM

@shleewhite
Copy link
Contributor Author

shleewhite commented Nov 21, 2024 •
edited
Loading

Small thing, but in the mobile menu, looks like the spacing between the two icons, and between the menu and the edge of the screen are a bit tighter in the figma.

Figma

Screenshot 2024-11-21 at 10 28 05 AM Current UI Screenshot 2024-11-21 at 10 28 15 AM

Thanks for catching that @dchyun!! it should be better now.

majedelass
majedelass reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@majedelass majedelass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment about the space between the logo (Helios Design System) and the nav links. From what I could tell, that was it! Nice work :D

@majedelass
Copy link
Contributor

Should we open this for review, or is there a reason to keep it in draft?

@shleewhite shleewhite marked this pull request as ready for review December 3, 2024 14:08
@shleewhite shleewhite requested review from a team as code owners December 3, 2024 14:08
@shleewhite shleewhite requested a review from majedelass December 3, 2024 14:08
majedelass
majedelass previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@majedelass majedelass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks good to me! Thanks for making these updates!

dchyun
dchyun previously approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@dchyun dchyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@majedelass majedelass requested review from alex-ju and didoo December 4, 2024 15:51
@majedelass majedelass dismissed stale reviews from dchyun and themself via 7ae4c9c December 4, 2024 20:23
@shleewhite shleewhite force-pushed the hds-4159/website-nav-update branch from 7ae4c9c to 2e881eb Compare December 5, 2024 19:27
HDS Content - Adding Writing Guidelines and Writing Style (#2576)
0dabac4 
Co-authored-by: Andrew Gendel <124841193+andgen404@users.noreply.github.com>
Co-authored-by: LilithJames-HDS <lilith.james@hashicorp.com>
Co-authored-by: Kristin Bradley <kristin.bradley@hashicorp.com>
Co-authored-by: Lee White <leewhite128@gmail.com>
Co-authored-by: Heather Larsen <hlarsen@hashicorp.com>
heatherlarsen
heatherlarsen reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@heatherlarsen heatherlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some minor todos and a couple of questions

majedelass
majedelass approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@majedelass majedelass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! :shipit:

jorytindall
jorytindall approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@jorytindall jorytindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@shleewhite shleewhite merged commit dd6c35a into main Dec 10, 2024
10 checks passed
@shleewhite shleewhite deleted the hds-4159/website-nav-update branch December 10, 2024 15:01
@hashicorp hashicorp deleted a comment from majedelass Dec 13, 2024
@hashicorp hashicorp deleted a comment from majedelass Dec 13, 2024
@hashicorp hashicorp deleted a comment from majedelass Dec 13, 2024
@hashicorp hashicorp deleted a comment from majedelass Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heatherlarsen heatherlarsen

@jorytindall jorytindall

@dchyun dchyun

@majedelass majedelass

@alex-ju alex-ju

@didoo didoo

Assignees
No one assigned
Labels
docs-website Content updates to the documentation website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@shleewhite @dchyun @majedelass @didoo @alex-ju @jorytindall @heatherlarsen @hashibot-hds