`SuperSelect` - search position (HDS-4254) #2612

KristinLBradley · 2024-12-17T18:35:54Z

📌 Summary

If merged, this PR adds the searchFieldPosition to SuperSelect enabling SuperSelect::Multiple to display the search field within the before options area instead of in the trigger area.

Showcase: https://hds-showcase-git-hds-4254-super-select-search-484150-hashicorp.vercel.app/components/form/super-select

🛠️ Detailed description

Updates ember-power-select version to 8.6.0 & above
Adds searchFieldPosition argument to SuperSelect components
- Sets value of "before-options" for argument

📸 Screenshots

🔗 External links

Jira ticket: HDS-4254

👀 Component checklist

Percy was checked for any visual regression
A changelog entry was added via Changesets if needed (see templates here)

💬 Please consider using conventional comments when reviewing this PR.

vercel · 2024-12-17T18:35:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
hds-showcase	✅ Ready (Inspect)	Visit Preview	Jan 7, 2025 5:55pm
hds-website	✅ Ready (Inspect)	Visit Preview	Jan 7, 2025 5:55pm

packages/components/src/components/hds/form/super-select/single/base.hbs

packages/components/src/components/hds/form/super-select/multiple/base.hbs

showcase/app/templates/components/form/super-select.hbs

…add preliminary Showcase examples

…Multiple SuperSelect, clean up Showcase

.changeset/new-paws-cross.md

shleewhite

🚢

alex-ju

This seems to require a rebase to resolve some conflicts in yarn.lock, otherwise it's good to be merged.

…add preliminary Showcase examples

…Multiple SuperSelect, clean up Showcase

…b.com/hashicorp/design-system into hds-4254-super-select-search-position # Conflicts: # yarn.lock

KristinLBradley · 2025-01-06T23:46:39Z

Resolved yarn.lock conflicts.

The merge-base changed after approval.

alex-ju · 2025-01-07T10:07:34Z

packages/components/package.json

@@ -52,7 +52,7 @@
    "ember-focus-trap": "^1.1.0",
    "ember-get-config": "^2.1.1",
    "ember-modifier": "^4.1.0",
-    "ember-power-select": "^8.2.0",
+    "ember-power-select": "^8.6.0",


we had two patch releases since we started the work on this one, so we should bump this to latest 8.6.2

Suggested change

"ember-power-select": "^8.6.0",

"ember-power-select": "^8.6.2",

of course, this would require a small adjustment to the changelog entry and a yarn.lock update

on a second thought, we have a version bump in #2625 (review) as well, so you can get this in as is.

So is this one ok to just merge now as is?

Yes.
However, we're having issues with getting it approved. They automatically get dismissed after the main was merged into it. Would you be able to force-push from local to see if we can overcome this?

The merge-base changed after approval.

# Conflicts: # showcase/package.json # yarn.lock

hashibot-hds added packages/components showcase labels Dec 17, 2024

KristinLBradley commented Dec 17, 2024

View reviewed changes

packages/components/src/components/hds/form/super-select/single/base.hbs Show resolved Hide resolved

KristinLBradley commented Dec 17, 2024

View reviewed changes

packages/components/src/components/hds/form/super-select/multiple/base.hbs Outdated Show resolved Hide resolved

KristinLBradley commented Dec 17, 2024

View reviewed changes

showcase/app/templates/components/form/super-select.hbs Outdated Show resolved Hide resolved

KristinLBradley added 2 commits December 18, 2024 11:51

HDS-4254 Update ember-power-select version

081f9a7

HDS-4254 Add searchFieldPosition to Single and Multiple SuperSelect, …

50080f9

…add preliminary Showcase examples

KristinLBradley force-pushed the hds-4254-super-select-search-position branch from cd56538 to 50080f9 Compare December 18, 2024 19:52

vercel bot deployed to Preview – hds-showcase December 18, 2024 19:54 View deployment

vercel bot deployed to Preview – hds-website December 18, 2024 19:56 View deployment

HDS-4254 Hard code value of searchFieldPosition to before-options in …

38577bb

…Multiple SuperSelect, clean up Showcase

vercel bot deployed to Preview – hds-showcase December 19, 2024 16:37 View deployment

vercel bot deployed to Preview – hds-website December 19, 2024 16:39 View deployment

HDS-4254 Add changeset

b4bc1d8

KristinLBradley changed the title ~~[DRAFT] SuperSelect - search position (HDS-4254)~~ SuperSelect - search position (HDS-4254) Dec 19, 2024

KristinLBradley marked this pull request as ready for review December 19, 2024 16:49

KristinLBradley requested a review from a team as a code owner December 19, 2024 16:49

vercel bot deployed to Preview – hds-showcase December 19, 2024 16:51 View deployment

vercel bot deployed to Preview – hds-website December 19, 2024 16:53 View deployment

Update new-paws-cross.md

a14b2d6

KristinLBradley commented Dec 19, 2024

View reviewed changes

.changeset/new-paws-cross.md Show resolved Hide resolved

vercel bot deployed to Preview – hds-showcase December 19, 2024 17:00 View deployment

vercel bot deployed to Preview – hds-website December 19, 2024 17:02 View deployment

KristinLBradley mentioned this pull request Dec 19, 2024

SuperSelect - docs for search position (HDS-4254) #2620

Merged

shleewhite previously approved these changes Dec 19, 2024

View reviewed changes

alex-ju reviewed Jan 6, 2025

View reviewed changes

KristinLBradley added 3 commits January 6, 2025 15:22

HDS-4254 Update ember-power-select version

20de27e

HDS-4254 Add searchFieldPosition to Single and Multiple SuperSelect, …

d80353f

…add preliminary Showcase examples

HDS-4254 Hard code value of searchFieldPosition to before-options in …

a4f48b8

…Multiple SuperSelect, clean up Showcase

Merge branch 'hds-4254-super-select-search-position' of https://githu…

cbee0c5

…b.com/hashicorp/design-system into hds-4254-super-select-search-position # Conflicts: # yarn.lock

KristinLBradley dismissed shleewhite’s stale review via cbee0c5 January 6, 2025 23:27

KristinLBradley requested a review from a team as a code owner January 6, 2025 23:27

hashibot-hds added packages/flight-icons packages/ember-flight-icons docs-website Content updates to the documentation website labels Jan 6, 2025

vercel bot deployed to Preview – hds-showcase January 6, 2025 23:29 View deployment

vercel bot deployed to Preview – hds-website January 6, 2025 23:31 View deployment

KristinLBradley requested review from alex-ju and shleewhite January 6, 2025 23:46

alex-ju previously approved these changes Jan 7, 2025

View reviewed changes

alex-ju reviewed Jan 7, 2025

View reviewed changes

alex-ju mentioned this pull request Jan 7, 2025

Upgrade minor / patch dependencies #2625

Merged

2 tasks

alex-ju previously approved these changes Jan 7, 2025

View reviewed changes

Merge branch 'main' into hds-4254-super-select-search-position

5317f2e

# Conflicts: # showcase/package.json # yarn.lock

hashibot-hds removed packages/flight-icons packages/ember-flight-icons docs-website Content updates to the documentation website labels Jan 7, 2025

alex-ju approved these changes Jan 7, 2025

View reviewed changes

vercel bot deployed to Preview – hds-showcase January 7, 2025 17:53 View deployment

vercel bot deployed to Preview – hds-website January 7, 2025 17:55 View deployment

KristinLBradley merged commit 2164713 into main Jan 7, 2025
14 checks passed

KristinLBradley deleted the hds-4254-super-select-search-position branch January 7, 2025 18:06

hashibot-hds mentioned this pull request Jan 7, 2025

Version Packages #2605

Merged

alex-ju added this to the design-system-components@4.16.0 milestone Feb 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`SuperSelect` - search position (HDS-4254) #2612

`SuperSelect` - search position (HDS-4254) #2612

KristinLBradley commented Dec 17, 2024 •

edited

Loading

vercel bot commented Dec 17, 2024 •

edited

Loading

shleewhite left a comment

alex-ju left a comment

KristinLBradley commented Jan 6, 2025

alex-ju Jan 7, 2025

alex-ju Jan 7, 2025

alex-ju Jan 7, 2025 •

edited

Loading

KristinLBradley Jan 7, 2025

alex-ju Jan 7, 2025

	"ember-power-select": "^8.6.0",
	"ember-power-select": "^8.6.2",

SuperSelect - search position (HDS-4254) #2612

SuperSelect - search position (HDS-4254) #2612

Conversation

KristinLBradley commented Dec 17, 2024 • edited Loading

📌 Summary

Related:

🛠️ Detailed description

📸 Screenshots

🔗 External links

👀 Component checklist

vercel bot commented Dec 17, 2024 • edited Loading

shleewhite left a comment

Choose a reason for hiding this comment

alex-ju left a comment

Choose a reason for hiding this comment

KristinLBradley commented Jan 6, 2025

alex-ju Jan 7, 2025

Choose a reason for hiding this comment

alex-ju Jan 7, 2025

Choose a reason for hiding this comment

alex-ju Jan 7, 2025 • edited Loading

Choose a reason for hiding this comment

KristinLBradley Jan 7, 2025

Choose a reason for hiding this comment

alex-ju Jan 7, 2025

Choose a reason for hiding this comment

`SuperSelect` - search position (HDS-4254) #2612

`SuperSelect` - search position (HDS-4254) #2612

KristinLBradley commented Dec 17, 2024 •

edited

Loading

vercel bot commented Dec 17, 2024 •

edited

Loading

alex-ju Jan 7, 2025 •

edited

Loading