Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuperSelect - search position (HDS-4254) #2612

Merged
merged 12 commits into from
Jan 7, 2025
Merged

SuperSelect - search position (HDS-4254) #2612

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
081f9a7
HDS-4254 Update ember-power-select version
KristinLBradley Dec 17, 2024
50080f9
HDS-4254 Add searchFieldPosition to Single and Multiple SuperSelect, …
KristinLBradley Dec 17, 2024
38577bb
HDS-4254 Hard code value of searchFieldPosition to before-options in …
KristinLBradley Dec 19, 2024
b4bc1d8
HDS-4254 Add changeset
KristinLBradley Dec 19, 2024
a14b2d6
Update new-paws-cross.md
KristinLBradley Dec 19, 2024
20de27e
HDS-4254 Update ember-power-select version
KristinLBradley Dec 17, 2024
d80353f
HDS-4254 Add searchFieldPosition to Single and Multiple SuperSelect, …
KristinLBradley Dec 17, 2024
a4f48b8
HDS-4254 Hard code value of searchFieldPosition to before-options in …
KristinLBradley Dec 19, 2024
bc3d15d
HDS-4254 Add changeset
KristinLBradley Dec 19, 2024
25dad04
Update new-paws-cross.md
KristinLBradley Dec 19, 2024
cbee0c5
Merge branch 'hds-4254-super-select-search-position' of https://githu…
KristinLBradley Jan 6, 2025
5317f2e
Merge branch 'main' into hds-4254-super-select-search-position
KristinLBradley Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/new-paws-cross.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@hashicorp/design-system-components": minor
---

`SuperSelect` updates including:
- Updated `ember-power-select` from `8.2.0` to `8.6.0`
- Added `searchFieldPosition="before-options"` to fix a11y issue in `Multiple` component
2 changes: 1 addition & 1 deletion packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"ember-focus-trap": "^1.1.0",
"ember-get-config": "^2.1.1",
"ember-modifier": "^4.1.0",
"ember-power-select": "^8.2.0",
"ember-power-select": "^8.6.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we had two patch releases since we started the work on this one, so we should bump this to latest 8.6.2

Suggested change
"ember-power-select": "^8.6.0",
"ember-power-select": "^8.6.2",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course, this would require a small adjustment to the changelog entry and a yarn.lock update

Copy link
Member

@alex-ju alex-ju Jan 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on a second thought, we have a version bump in #2625 (review) as well, so you can get this in as is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is this one ok to just merge now as is?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.
However, we're having issues with getting it approved. They automatically get dismissed after the main was merged into it. Would you be able to force-push from local to see if we can overcome this?

"ember-stargate": "^0.4.3",
"ember-style-modifier": "^4.4.0",
"ember-truth-helpers": "^4.0.3",
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/components/hds/form/super-select/multiple/base.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
@search={{@search}}
@searchEnabled={{@searchEnabled}}
@searchField={{@searchField}}
@searchFieldPosition="before-options"
@searchMessage={{@searchMessage}}
@searchPlaceholder={{this.searchPlaceholder}}
@selected={{@selected}}
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/components/hds/form/super-select/multiple/field.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
@search={{@search}}
@searchEnabled={{@searchEnabled}}
@searchField={{@searchField}}
@searchFieldPosition="before-options"
@searchMessage={{@searchMessage}}
@searchPlaceholder={{@searchPlaceholder}}
@selected={{@selected}}
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/components/hds/form/super-select/single/base.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
@search={{@search}}
@searchEnabled={{@searchEnabled}}
@searchField={{@searchField}}
@searchFieldPosition="before-options"
@searchMessage={{@searchMessage}}
@searchPlaceholder={{this.searchPlaceholder}}
@selected={{@selected}}
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/components/hds/form/super-select/single/field.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
@search={{@search}}
@searchEnabled={{@searchEnabled}}
@searchField={{@searchField}}
@searchFieldPosition="before-options"
@searchMessage={{@searchMessage}}
@searchPlaceholder={{@searchPlaceholder}}
@selected={{@selected}}
Expand Down
2 changes: 1 addition & 1 deletion showcase/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"ember-load-initializers": "^2.1.2",
"ember-modifier": "^4.1.0",
"ember-page-title": "^8.2.3",
"ember-power-select": "^8.2.0",
"ember-power-select": "^8.6.0",
"ember-qunit": "^8.1.0",
"ember-resolver": "^11.0.1",
"ember-set-helper": "^3.0.1",
Expand Down
2 changes: 1 addition & 1 deletion website/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"ember-meta": "^2.0.0",
"ember-modifier": "^4.1.0",
"ember-page-title": "^8.2.3",
"ember-power-select": "^8.2.0",
"ember-power-select": "^8.6.0",
"ember-prism": "^0.13.0",
"ember-qunit": "^8.1.0",
"ember-resolver": "^11.0.1",
Expand Down
2,609 changes: 1,390 additions & 1,219 deletions yarn.lock
View file
Open in desktop

Large diffs are not rendered by default.

Loading