Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade minor / patch dependencies #2625

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Conversation

dchyun
Copy link
Contributor

@dchyun dchyun commented Dec 23, 2024 β€’

πŸ“Œ Summary

If merged, this PR would upgrade dependencies to the latest minor versions in the components and ember-flight-icons packages

πŸ› οΈ Detailed description

Upgrades will be made to the following dependencies.

  • @ember/render-modifiers from 2.0.5 to 2.1.0
  • @ember/addon-shim from 1.8.7 to 1.9.0
  • clipboard-polyfill from 4.1.0 to 4.1.1
  • decorator-transforms from 1.1.0 to 1.2.1
  • ember-a11y-refocus from 4.1.3 to 4.1.4
  • ember-element-helper from 0.8.5 to 0.8.6
  • ember-focus-trap from 1.1.0 to 1.1.1
  • ember-modifier from 4.1.0 to 4.2.0
  • ember-power-select from 8.2.0 to 8.6.1
  • sass from 1.69.5 to 1.83.0

The intent is to merge this PR following the other upgrades listed below to avoid significant conflicts.

πŸ”— External links

Jira ticket: HDS-4252


πŸ‘€ Component checklist

πŸ’¬ Please consider using conventional comments when reviewing this PR.

Sorry, something went wrong.

Copy link

vercel bot commented Dec 23, 2024 β€’

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
hds-showcase βœ… Ready (Inspect) Visit Preview Jan 9, 2025 6:29pm
hds-website βœ… Ready (Inspect) Visit Preview Jan 9, 2025 6:29pm

MelSumner
MelSumner previously approved these changes Jan 6, 2025
alex-ju
alex-ju previously approved these changes Jan 7, 2025
"ember-page-title": "^8.2.3",
"ember-power-select": "^8.2.0",
"ember-power-select": "^8.6.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They released a new patch recently, but could be bumped in #2612 (review) too, depending on which one gets in first.

Suggested change
"ember-power-select": "^8.6.1",
"ember-power-select": "^8.6.2",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other one got in first. I'd appreciate if we can bump this to 8.6.2 (it fixes an accessibility issue)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgraded to 8.6.2. Also moved the changeset entry for the upgrade from the super-select to the general list of upgrades.

`SuperSelect` updates including:
- Updated `ember-power-select` from `8.2.0` to `8.6.0`
- Added `searchFieldPosition="before-options"` to fix a11y issue in `Multiple` component
`SuperSelect` - Added `searchFieldPosition="before-options"` to fix a11y issue in `Multiple` component
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ™Œ

@dchyun dchyun merged commit 1ef4f62 into main Jan 9, 2025
14 checks passed
@dchyun dchyun deleted the dchyun/upgrade-dependencies branch January 9, 2025 18:40
@hashibot-hds hashibot-hds mentioned this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants