Table, Multi-select: Add note to docs (HDS-4273)
#2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
This comment was marked as resolved.
This comment was marked as resolved.
didoo
previously approved these changes
Jan 24, 2025
website/docs/components/table/table/partials/code/how-to-use.md
Outdated
Show resolved
Hide resolved
|
@didoo Question: With this update to the docs, what should I do with the broader Jira ticket? Leave it open or set it to blocked or...? |
didoo
approved these changes
Jan 24, 2025
Probably "Needs more info"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR updates the multi-select Table docs to add a note advising consumers to set an identityKey value in order to persist checkbox state.
👉 See related comment in PR to fix multi select Table bug.
Preview: https://hds-website-git-hds-4273-table-multi-select-do-e89064-hashicorp.vercel.app/components/table/table?tab=code#multi-select-table-using-a-model
📸 Screenshots
Added text is within the Info box
🔗 External links
👀 Component checklist
[ ] Percy was checked for any visual regression[ ] A changelog entry was added via Changesets if needed (see templates here)💬 Please consider using conventional comments when reviewing this PR.