Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: add identity key note to advanced table docs #2669

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

shleewhite
Copy link
Contributor

📌 Summary

Following up from #2667, adding the same note to the AdvancedTable docs.

Preview

📸 Screenshots

Screenshot 2025-01-24 at 1 40 35 PM


💬 Please consider using conventional comments when reviewing this PR.

@shleewhite shleewhite requested review from a team as code owners January 24, 2025 18:42
Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Jan 24, 2025 6:42pm
hds-website ✅ Ready (Inspect) Visit Preview Jan 24, 2025 6:42pm

@hashibot-hds hashibot-hds added the docs-website Content updates to the documentation website label Jan 24, 2025
Copy link
Contributor

@jorytindall jorytindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good to me. I'm not 100% sold on whether the point about the identityKey needs to be in a banner, it seems like it could just be included in the previous sentence, but not a blocker per se.

@shleewhite shleewhite merged commit 67717f7 into main Feb 4, 2025
10 checks passed
@shleewhite shleewhite deleted the chore/update-advanced-table-docs branch February 4, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants