Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pnpm πŸŽ‰ #2671

Merged
merged 9 commits into from
Feb 21, 2025
Merged

feat: pnpm πŸŽ‰ #2671

merged 9 commits into from
Feb 21, 2025

Conversation

aklkv
Copy link
Collaborator

@aklkv aklkv commented Jan 25, 2025

πŸ“Œ Summary

Swap out yarn for pnpm

πŸ› οΈ Detailed description

  • ENABLE_EXPERIMENTAL_COREPACK need to be added to all environments on vercel side

When rebasing make sure you have corepack either through node or homebrew and run following command to get rid of old node_modules from the root of the monorepo npx npkill -D -x -y

πŸ“Έ Screenshots

πŸ”— External links

Jira ticket: HDS-4488
Figma file: [if it applies]


πŸ‘€ Component checklist

πŸ’¬ Please consider using conventional comments when reviewing this PR.

@aklkv aklkv self-assigned this Jan 25, 2025
Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
hds-showcase βœ… Ready (Inspect) Visit Preview Feb 20, 2025 5:29pm
hds-website βœ… Ready (Inspect) Visit Preview Feb 20, 2025 5:29pm

Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback! Product testing went well – so we're good to get this in.

@alex-ju alex-ju merged commit 89a769b into main Feb 21, 2025
14 checks passed
@alex-ju alex-ju deleted the feat/pnpm branch February 21, 2025 15:24
@hashibot-hds hashibot-hds mentioned this pull request Feb 21, 2025
shleewhite pushed a commit that referenced this pull request Mar 10, 2025
Co-authored-by: Alex <alex-ju@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants