-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pnpm π #2671
Merged
feat: pnpm π #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Co-authored-by: Alex <alex-ju@users.noreply.github.com>
Co-authored-by: Alex <alex-ju@users.noreply.github.com>
alex-ju
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the feedback! Product testing went well β so we're good to get this in.
shleewhite
approved these changes
Feb 20, 2025
Merged
shleewhite
pushed a commit
that referenced
this pull request
Mar 10, 2025
Co-authored-by: Alex <alex-ju@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs-website
Content updates to the documentation website
packages/components
packages/ember-flight-icons
packages/flight-icons
packages/tokens
showcase
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
Swap out
yarn
forpnpm
π οΈ Detailed description
ENABLE_EXPERIMENTAL_COREPACK
need to be added to all environments onvercel
sideWhen rebasing make sure you have
corepack
either throughnode
orhomebrew
and run following command to get rid of oldnode_modules
from the root of the monoreponpx npkill -D -x -y
πΈ Screenshots
π External links
Jira ticket: HDS-4488
Figma file: [if it applies]
π Component checklist
π¬ Please consider using conventional comments when reviewing this PR.