Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase - Add min-height to Shw::Label #2746

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Draft

Showcase - Add min-height to Shw::Label #2746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions showcase/app/styles/showcase-components/label.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

.shw-label {
@include shw-font-family("rubik");
min-height: 0.96rem; // needed to avoid vertical collapsing when the label is empty
Copy link
Contributor

@KristinLBradley KristinLBradley Mar 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why so specific? (vs. a value like "1px" or something)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to have the same (min) height as the other labels of the sibling items, to keep visual alignment.

margin: 0 0 10px 0;
color: #545454;
font-size: 0.8rem;
Expand Down