Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout::Flex
- Component implementation #2751base: main
Are you sure you want to change the base?
Layout::Flex
- Component implementation #2751Changes from 37 commits
9ba9856
351f687
ee33fc3
1ea4687
1c53aed
e22a99e
557c9b8
7c6e08b
421f2ca
3f2161b
9c841e2
cc0e226
407e201
8457ad5
abf1c2f
20f8b5c
a1b7df2
b29b31c
041523a
0c61309
8cfb28d
5d6af0e
a04ba5e
c8b4531
cda03e8
0bda2b0
f320161
df0ad0b
24cb5f7
97c64ea
8e79f13
11d2bbe
9c11ee4
757e032
3542b3c
566566c
e0a7906
c0cd637
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KristinLBradley I am open to alternatives for this argument (and to discuss if we want to keep it or not)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the possible use cases & do they seem common?
This seems like a confusing feature that perhaps could be left up to consumers to implement something for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Examples of where it's used in our HDS components:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'm more wondering if there are common use cases for not wanting to set it to true.
(i.e. for not including
min-width: 0;
)