Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdvancedTable: use correct icons in th-button-expand #2777

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shleewhite
Copy link
Contributor

@shleewhite shleewhite commented Mar 18, 2025

📌 Summary

If merged, this PR would update th-button-expand to use icons that match what is in Figma. This PR also fixes a couple out of date examples of th cells and th-button-expand towards the bottom of the showcase page.

📸 Screenshots

Expected from design
Screenshot 2025-03-18 at 3 50 02 PM

Current

Screenshot 2025-03-18 at 4 26 36 PM

After

Screenshot 2025-03-18 at 3 55 01 PM

🔗 External links

Jira ticket: HDS-4673
Figma file: https://www.figma.com/design/iweq3r2Pi8xiJfD9e6lOhF/HDS-Components-v2.0?m=auto&node-id=72039-3972&t=80TE8WBi8bf9PGcm-1


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

@shleewhite shleewhite requested a review from andgen404 March 18, 2025 19:54
@shleewhite shleewhite requested a review from a team as a code owner March 18, 2025 19:54
Copy link

vercel bot commented Mar 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Mar 18, 2025 8:25pm
hds-website ✅ Ready (Inspect) Visit Preview Mar 18, 2025 8:25pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants