hds-code-editor - Attach EditorView instance to modified element
#2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zamoore
changed the title
hds-code-editor - Attach EditorView instance to modified element
zamoore
force-pushed
the
zamoore/HDS-4677/attach-editor-instance-to-dom
branch
from
6cd290f to
897cc16
Compare
alex-ju
previously approved these changes
Mar 25, 2025
Co-authored-by: Alex <alex-ju@users.noreply.github.com>
zamoore
force-pushed
the
zamoore/HDS-4677/attach-editor-instance-to-dom
branch
from
9232cf9 to
515935d
Compare
shleewhite
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR will attach the CodeMirror
EditorViewinstance to the element modified by thehds-code-editormodifier.🛠️ Detailed description
Why?
Needed for supporting editor interactions in the acceptance tests of our downstream consumers
How?
When the editor is instantiated by the modifier, we attach the instance to the modified DOM Element.
🔗 External links
Jira ticket: HDS-4677
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.