Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated export of icons from Figma #2782

Merged
merged 4 commits into from
Mar 28, 2025
Merged

Updated export of icons from Figma #2782

merged 4 commits into from
Mar 28, 2025

Conversation

hashibot-hds
Copy link
Collaborator

@hashibot-hds hashibot-hds commented Mar 20, 2025

πŸ“Œ Summary

This is an automated PR opened by the Hashibot-HDS using the GitHub Action Sync & Build Icons.

πŸ› οΈ Detailed description

  • Duo and Ping identity service icons have been added.

Jira ticket: HDS-4477


πŸ‘€ Component checklist

Copy link

vercel bot commented Mar 20, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
hds-showcase βœ… Ready (Inspect) Visit Preview Mar 25, 2025 5:02pm
hds-website βœ… Ready (Inspect) Visit Preview Mar 25, 2025 5:02pm

@alex-ju
Copy link
Member

alex-ju commented Mar 21, 2025

The issue, as I see it, is that in the current setup the new (unreleased) icons are available to website but not to packages/components. Hence we list them in the icon library but the Hds::Icon component complains about them not having valid names.

I pushed a commit to pin the flight-icon version in website, to prevent it from picking up new (unreleased) icons from the catalog. Ideally, we'd only expose those icons when released, so this will keep the icon library accurate as well.

Note that changesets will automatically bump the flight-icon version in website when a new version is released.

Co-authored-by: Dylan Hyun <dylan.hyun@hashicorp.com>
@heatherlarsen
Copy link
Contributor

@alex-ju so it's to be expected that we wouldn't see the new icons in the icon library preview?

@alex-ju
Copy link
Member

alex-ju commented Mar 25, 2025

@alex-ju so it's to be expected that we wouldn't see the new icons in the icon library preview?

yes, unfortunately, that's the case: it will not show on the website before it gets published, but it will also not show in a preview link. we can still review the SVG as it is, by checking the file, but I don't think we expect any surprises really (or differences from Figma)

@andgen404 andgen404 requested review from dchyun and a team March 26, 2025 04:28
@andgen404 andgen404 merged commit 62021e7 into main Mar 28, 2025
16 checks passed
@andgen404 andgen404 deleted the hds-icon-export-abcabaf branch March 28, 2025 20:27
alex-ju added a commit that referenced this pull request Mar 31, 2025
Reverting the dependency change introduced in #2782
@hashibot-hds hashibot-hds mentioned this pull request Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants