SideNav
- Conditionally set aria-labelledby
#2788
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would set the
aria-labelledby
attribute in theSideNav
toggle button, only if the@ariaLabel
argument is not provided.🛠️ Detailed description
Currently in the
SideNav
component's toggle button, there is a hardcodedaria-labelledby
value ofhds-side-nav-header
present. The@ariaLabel
argument sets thearia-label
on the toggle button, but when this argument is set, the existingaria-labelledby
is not removed. This leads to botharia-label
andaria-labelledby
being present on the toggle button. Sincearia-labelledby
overridesaria-label
for screenreaders, the providedaria-label
value is never announced.To correct this behavior, the functionality has been changed so the hardcoded
aria-labelledby
is only set when the@ariaLabel
argument is not used.📸 Screenshots
Before
After
🔗 External links
Jira ticket: HDS-4549
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.