Update proxmox-api-go to 205f18a #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbajolet-hashicorp
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last update of
proxmox-api-gocaused a regression which got intov1.1.1unfortunately. See the details in the upstream MR: Telmate/proxmox-api-go#232proxmox-api-gohas seen quite a lot refactoring since the last update, but all changes seem to be internally, without breaking our code.I ran a number of tests with a PVE 7.3 which all worked fine, but as with the last API bump I cannot rule out breakage in all features this plugin supports.
Let's hope
proxmox-api-gointroduces versioning at some point to make updates at least a bit more predictable (there are plans for this at least: Telmate/proxmox-api-go#171 (comment)).Closes #146
Closes #150