Adding darwin/386 as part of unsupported GOOS/GOARCH pair in builds.sh

[kp2099]

Currently running make bin fails with Unsupported GOOS/GOARCH pair.

1 errors occurred:
--> darwin/386 error: exit status 2
Stderr: go: unsupported GOOS/GOARCH pair darwin/386

make: *** [bin] Error 1

[hashicorp-cla-app]

All committers have signed the CLA.

[hashicorp-cla-app]

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

_{Have you signed the CLA already but the status is still pending? Recheck it.}

[lbajolet-hashicorp]

Hi @kp2099,

Thanks for the PR, I'm surprised you hit this as make bin is not typically the kind of command used to build Packer, in general during development we tend to run make dev as it builds the binary for the architecture you build for. I'm not sure build.sh is used by anyone, it hasn't been maintained in a while, we should probably consider removing it and its references from the Makefile.

That said, the change makes sense, I don't remember when's the last time there's been a non 64-bit x86 macOS machine released, and it'll only get rarer as time goes by, but if the script tries that, we should add this exception in the meantime.

In the current state I won't be able to merge the PR though as you haven't signed the CLA, could you do this? Once it's signed, I can run the tests/merge ASAP, thanks!

[kp2099]

hi @lbajolet-hashicorp i have signed the CLA. Yes i agree i think we should make changes to Makefile to remove references to builds.sh. We can consider that in a different PR. Thanks a lot for the approval!

[lbajolet-hashicorp]

It can most definitely be done in a later PR indeed, for now we can merge this.
The only thing failing being Vercel, this is fine, I'm merging the PR now.