Skip to content

Commit e58f601

Browse files
committed
add changelog entry and PR remarks
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
1 parent bfb17ce commit e58f601

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# UNRELEASED
22

3+
IMPROVEMENETS
4+
5+
* chore: Add a flag to skip legacy duplicate telemetry. [GH-630](https://github.com/hashicorp/raft/pull/630)
6+
37
# 1.7.0 (June 5th, 2024)
48

59
CHANGES

api.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -218,8 +218,8 @@ type Raft struct {
218218
// prevote feature is disabled if set to true.
219219
preVoteDisabled bool
220220

221-
// noLegacyTelemetry allow to skip the legacy metrics to avoid duplicates.
222-
// legacy metrics are which has `_peer_name` as metric suffix instead as labels.
221+
// noLegacyTelemetry allows to skip the legacy metrics to avoid duplicates.
222+
// legacy metrics are those that have `_peer_name` as metric suffix instead as labels.
223223
// e.g: raft_replication_heartbeat_peer0
224224
noLegacyTelemetry bool
225225
}

config.go

+5-5
Original file line numberDiff line numberDiff line change
@@ -235,13 +235,13 @@ type Config struct {
235235
// PreVoteDisabled deactivate the pre-vote feature when set to true
236236
PreVoteDisabled bool
237237

238-
// skipStartup allows NewRaft() to bypass all background work goroutines
239-
skipStartup bool
240-
241-
// NoLegacyTelemetry allow to skip the legacy metrics to avoid duplicates.
242-
// legacy metrics are which has `_peer_name` as metric suffix instead as labels.
238+
// NoLegacyTelemetry allows to skip the legacy metrics to avoid duplicates.
239+
// legacy metrics are those that have `_peer_name` as metric suffix instead as labels.
243240
// e.g: raft_replication_heartbeat_peer0
244241
NoLegacyTelemetry bool
242+
243+
// skipStartup allows NewRaft() to bypass all background work goroutines
244+
skipStartup bool
245245
}
246246

247247
func (conf *Config) getOrCreateLogger() hclog.Logger {

0 commit comments

Comments
 (0)