Add a log line on active node when sending snapshot to a follower #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmichael
reviewed
Mar 11, 2025
replication.go
Outdated
| @@ -337,6 +337,7 @@ func (r *Raft) sendLatestSnapshot(s *followerReplication) (bool, error) { | |||
| peer := s.peer | |||
| s.peerLock.RUnlock() | |||
|
|
|||
| r.logger.Info("installing snapshot on", "peer", peer, "id", snapID, "size", req.Size) | |||
There was a problem hiding this comment.
Suggested change
| r.logger.Info("installing snapshot on", "peer", peer, "id", snapID, "size", req.Size) | |
| r.logger.Info("installing snapshot on", "peer", peer.ID, "id", snapID, "size", req.Size) |
Also do you mind adding peer.ID and snapID to the other two log lines in this func? It's nice when related log lines have the appropriate context to tie them all together.
There was a problem hiding this comment.
Good shout, Michael, thanks! Fixed in 9c2797b
…fix - use peer.ID instead of peer as a value in log line
schmichael
previously approved these changes
Mar 11, 2025
|
I spoke with our support a bit more, they also requested a log entry when we're opening a snapshot. Added in 9c0ae81 |
raskchanky
approved these changes
Mar 18, 2025
kubawi
deleted the
kubawi/VAULT-29278/add-logging-on-active-node-when-sending-snapshot
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is motivated by a request from Vault's support to make it easier to understand the progress of replication.
Currently, we do some logging on the standby nodes, but our support would like to be able to see what is happening in the logs earlier, especially in Vault deployments when the active node is slow/overwhelmed or when it has a big database.