Allow for the use of service serving certificates with OpenShift #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benemon is this something we still want to pursue? If so, can you rebase to resolve the conflict? Thanks! |
|
Hi @p0pr0ck5 - apologies, I lost focus on this. Let me review the conflict and see what needs to be resolved here. |
|
@p0pr0ck5 I've resolved the conflicts as requested. |
|
Will this PR be merged for use on OpenShift? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When TFE is deployed into OpenShift environments, a platform feature called 'service serving certificates' can be leveraged to generate, maintain, and rotate platform-issued certificates for components deployed onto it. Service Serving Certificates.
In the context of TFE, this feature allows us to sidestep the creation, deployment, and management of an internal certificate chain, by using one generated on behalf of the TFE workload by the OpenShift platform.
We can also use this feature to provide the platform's CA bundle to the TFE workload as a configmap, which in turn allows us to trust these service serving certificates.
Use of this feature, in conjunction with OpenShift Routes / ClusterIP services eases the onboarding of workloads into OpenShift, without requiring customisation of the helm chart, as all certificate operation will be offloaded to the platform.
This PR: