Skip to content

Commit 4d0a116

Browse files
fix: bigtable - avoid instance recreation due to node_scaling_factor addition in 6.34.0 for existing clusters (#13902) (#22674)
[upstream:bc107b1cc3314d2efadb459e69a4db7ac501503a] Signed-off-by: Modular Magician <magic-modules@google.com>
1 parent 03958ed commit 4d0a116

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

.changelog/13902.txt

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:bug
2+
bigtable: fixed forced instance recreation due to addition of `cluster.node_scaling_factor` for `google_bigtable_instance` in 6.34.0
3+
```

google/services/bigtable/resource_bigtable_instance.go

+2
Original file line numberDiff line numberDiff line change
@@ -537,6 +537,8 @@ func flattenBigtableCluster(c *bigtable.ClusterInfo) map[string]interface{} {
537537
nodeScalingFactor = "NodeScalingFactor1X"
538538
case bigtable.NodeScalingFactor2X:
539539
nodeScalingFactor = "NodeScalingFactor2X"
540+
default:
541+
nodeScalingFactor = "NodeScalingFactor1X"
540542
}
541543

542544
cluster := map[string]interface{}{

google/services/bigtable/resource_bigtable_instance_internal_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,8 @@ func TestUnitBigtable_flattenBigtableCluster(t *testing.T) {
169169
"storage_target": 60,
170170
},
171171
},
172-
// unspecified node scaling factor in input will lead to an empty string here
173-
"node_scaling_factor": "",
172+
// unspecified node scaling factor in input will default to 1X
173+
"node_scaling_factor": "NodeScalingFactor1X",
174174
},
175175
},
176176
"HDD manual scaling": {

0 commit comments

Comments
 (0)