Skip to content

Commit 559830c

Browse files
Add warning notes for field loginHint and gcipSettings in IAP Settings. (#12678) (#20829)
[upstream:c6cb3e68e135752461033f1f85849095b445b5e3] Signed-off-by: Modular Magician <magic-modules@google.com>
1 parent 4e20621 commit 559830c

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

.changelog/12678.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:none
2+
Add warning notes for field loginHint and gcipSettings in IAP Settings.
3+
```

google/services/iap/resource_iap_settings.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -113,10 +113,11 @@ If undefined, IAP will not apply any special logic to OPTIONS requests.`,
113113
},
114114
},
115115
"gcip_settings": {
116-
Type: schema.TypeList,
117-
Optional: true,
118-
Description: `GCIP claims and endpoint configurations for 3p identity providers.`,
119-
MaxItems: 1,
116+
Type: schema.TypeList,
117+
Optional: true,
118+
Description: `GCIP claims and endpoint configurations for 3p identity providers.
119+
* Enabling gcipSetting significantly changes the way IAP authenticates users. Identity Platform does not support IAM, so IAP will not enforce any IAM policies for requests to your application.`,
120+
MaxItems: 1,
120121
Elem: &schema.Resource{
121122
Schema: map[string]*schema.Schema{
122123
"login_page_uri": {
@@ -168,7 +169,8 @@ can be configured. The possible values are:
168169
Enables redirect to primary IDP by skipping Google's login screen.
169170
(https://developers.google.com/identity/protocols/OpenIDConnect#hd-param)
170171
Note: IAP does not verify that the id token's hd claim matches this value
171-
since access behavior is managed by IAM policies.`,
172+
since access behavior is managed by IAM policies.
173+
* loginHint setting is not a replacement for access control. Always enforce an appropriate access policy if you want to restrict access to users outside your domain.`,
172174
},
173175
"programmatic_clients": {
174176
Type: schema.TypeList,

website/docs/r/iap_settings.html.markdown

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ The following arguments are supported:
151151
* `gcip_settings` -
152152
(Optional)
153153
GCIP claims and endpoint configurations for 3p identity providers.
154+
* Enabling gcipSetting significantly changes the way IAP authenticates users. Identity Platform does not support IAM, so IAP will not enforce any IAM policies for requests to your application.
154155
Structure is [documented below](#nested_access_settings_gcip_settings).
155156

156157
* `cors_settings` -
@@ -220,6 +221,7 @@ The following arguments are supported:
220221
(https://developers.google.com/identity/protocols/OpenIDConnect#hd-param)
221222
Note: IAP does not verify that the id token's hd claim matches this value
222223
since access behavior is managed by IAM policies.
224+
* loginHint setting is not a replacement for access control. Always enforce an appropriate access policy if you want to restrict access to users outside your domain.
223225

224226
* `programmatic_clients` -
225227
(Optional)

0 commit comments

Comments
 (0)