Update netapp tests to use bootstrapped networks (#13877) (#22650)

[upstream:2bd90791ede9b76e572fd50cb52628d6995c3c43]

Signed-off-by: Modular Magician <magic-modules@google.com>

Author: modular-magician

google/services/netapp/resource_netapp_storage_pool_generated_test.go

@@ -34,6 +34,7 @@ func TestAccNetappStoragePool_storagePoolCreateExample(t *testing.T) {
 	t.Parallel()
 
 	context := map[string]interface{}{
+		"network_name":  acctest.BootstrapSharedServiceNetworkingConnection(t, "gcnv-network-config-1", acctest.ServiceNetworkWithParentService("netapp.servicenetworking.goog")),
 		"random_suffix": acctest.RandString(t, 10),
 	}
 
@@ -57,37 +58,8 @@ func TestAccNetappStoragePool_storagePoolCreateExample(t *testing.T) {
 
 func testAccNetappStoragePool_storagePoolCreateExample(context map[string]interface{}) string {
 	return acctest.Nprintf(`
-# Create a network or use datasource to reference existing network
-resource "google_compute_network" "peering_network" {
-  name = "tf-test-test-network%{random_suffix}"
-}
-
-# Reserve a CIDR for NetApp Volumes to use
-# When using shared-VPCs, this resource needs to be created in host project
-resource "google_compute_global_address" "private_ip_alloc" {
-  name          = "tf-test-test-address%{random_suffix}"
-  purpose       = "VPC_PEERING"
-  address_type  = "INTERNAL"
-  prefix_length = 16
-  network       = google_compute_network.peering_network.id
-}
-
-# Create a Private Service Access connection
-# When using shared-VPCs, this resource needs to be created in host project
-resource "google_service_networking_connection" "default" {
-  network                 = google_compute_network.peering_network.id
-  service                 = "netapp.servicenetworking.goog"
-  reserved_peering_ranges = [google_compute_global_address.private_ip_alloc.name]
-}
-
-# Modify the PSA Connection to allow import/export of custom routes
-# When using shared-VPCs, this resource needs to be created in host project
-resource "google_compute_network_peering_routes_config" "route_updates" {
-  peering = google_service_networking_connection.default.peering
-  network = google_compute_network.peering_network.name
-
-  import_custom_routes = true
-  export_custom_routes = true
+data "google_compute_network" "default" {
+  name = "%{network_name}"
 }
 
 # Create a storage pool
@@ -98,7 +70,7 @@ resource "google_netapp_storage_pool" "test_pool" {
   location = "us-central1"
   service_level = "PREMIUM"
   capacity_gib = "2048"
-  network = google_compute_network.peering_network.id
+  network = data.google_compute_network.default.id
 }
 `, context)
 }

google/services/netapp/resource_netapp_storage_pool_test.go

@@ -14,6 +14,7 @@ func TestAccNetappStoragePool_storagePoolCreateExample_update(t *testing.T) {
 	t.Parallel()
 
 	context := map[string]interface{}{
+		"network_name":  acctest.BootstrapSharedServiceNetworkingConnection(t, "gcnv-network-config-1", acctest.ServiceNetworkWithParentService("netapp.servicenetworking.goog")),
 		"random_suffix": acctest.RandString(t, 10),
 	}
 
@@ -46,32 +47,16 @@ func TestAccNetappStoragePool_storagePoolCreateExample_update(t *testing.T) {
 func testAccNetappStoragePool_storagePoolCreateExample_full(context map[string]interface{}) string {
 	return acctest.Nprintf(`
 
-resource "google_compute_network" "peering_network" {
-  name = "tf-test-network%{random_suffix}"
-}
-
-# Create an IP address
-resource "google_compute_global_address" "private_ip_alloc" {
-  name          = "tf-test-address%{random_suffix}"
-  purpose       = "VPC_PEERING"
-  address_type  = "INTERNAL"
-  prefix_length = 16
-  network       = google_compute_network.peering_network.id
-}
-
-# Create a private connection
-resource "google_service_networking_connection" "default" {
-  network                 = google_compute_network.peering_network.id
-  service                 = "netapp.servicenetworking.goog"
-  reserved_peering_ranges = [google_compute_global_address.private_ip_alloc.name]
+data "google_compute_network" "default" {
+    name = "%{network_name}"
 }
 
 resource "google_netapp_storage_pool" "test_pool" {
   name = "tf-test-pool%{random_suffix}"
   location = "us-central1"
   service_level = "PREMIUM"
   capacity_gib = "2048"
-  network = google_compute_network.peering_network.id
+  network = data.google_compute_network.default.id
   active_directory      = ""
   description           = "this is a test description"
   kms_config            = ""
@@ -88,32 +73,16 @@ resource "google_netapp_storage_pool" "test_pool" {
 func testAccNetappStoragePool_storagePoolCreateExample_update(context map[string]interface{}) string {
 	return acctest.Nprintf(`
 
-resource "google_compute_network" "peering_network" {
-  name = "tf-test-network%{random_suffix}"
-}
-
-# Create an IP address
-resource "google_compute_global_address" "private_ip_alloc" {
-  name          = "tf-test-address%{random_suffix}"
-  purpose       = "VPC_PEERING"
-  address_type  = "INTERNAL"
-  prefix_length = 16
-  network       = google_compute_network.peering_network.id
-}
-
-# Create a private connection
-resource "google_service_networking_connection" "default" {
-  network                 = google_compute_network.peering_network.id
-  service                 = "netapp.servicenetworking.goog"
-  reserved_peering_ranges = [google_compute_global_address.private_ip_alloc.name]
+data "google_compute_network" "default" {
+    name = "%{network_name}"
 }
 
 resource "google_netapp_storage_pool" "test_pool" {
   name = "tf-test-pool%{random_suffix}"
   location = "us-central1"
   service_level = "PREMIUM"
   capacity_gib = "4096"
-  network = google_compute_network.peering_network.id
+  network = data.google_compute_network.default.id
   active_directory      = ""
   description           = "this is test"
   kms_config            = ""
@@ -156,32 +125,16 @@ func TestAccNetappStoragePool_autoTieredStoragePoolCreateExample_update(t *testi
 
 func testAccNetappStoragePool_autoTieredStoragePoolCreateExample_full(context map[string]interface{}) string {
 	return acctest.Nprintf(`
-resource "google_compute_network" "peering_network" {
-  name = "tf-test-network%{random_suffix}"
-}
-
-# Create an IP address
-resource "google_compute_global_address" "private_ip_alloc" {
-  name          = "tf-test-address%{random_suffix}"
-  purpose       = "VPC_PEERING"
-  address_type  = "INTERNAL"
-  prefix_length = 16
-  network       = google_compute_network.peering_network.id
-}
-
-# Create a private connection
-resource "google_service_networking_connection" "default" {
-  network                 = google_compute_network.peering_network.id
-  service                 = "netapp.servicenetworking.goog"
-  reserved_peering_ranges = [google_compute_global_address.private_ip_alloc.name]
+data "google_compute_network" "default" {
+    name = "%{network_name}"
 }
 
 resource "google_netapp_storage_pool" "test_pool" {
   name = "tf-test-pool%{random_suffix}"
   location = "us-east4"
   service_level = "PREMIUM"
   capacity_gib = "2048"
-  network = google_compute_network.peering_network.id
+  network = data.google_compute_network.default.id
   active_directory      = ""
   description           = "this is a test description"
   kms_config            = ""

website/docs/r/netapp_storage_pool.html.markdown

@@ -52,12 +52,7 @@ To get more information about StoragePool, see:
     * [Quickstart documentation](https://cloud.google.com/netapp/volumes/docs/get-started/quickstarts/create-storage-pool)
     * [Regional Flex zone switch](https://cloud.google.com/netapp/volumes/docs/configure-and-use/storage-pools/edit-or-delete-storage-pool#switch_active_and_replica_zones)
 
-<div class = "oics-button" style="float: right; margin: 0 0 -15px">
-  <a href="https://console.cloud.google.com/cloudshell/open?cloudshell_git_repo=https%3A%2F%2Fgithub.com%2Fterraform-google-modules%2Fdocs-examples.git&cloudshell_image=gcr.io%2Fcloudshell-images%2Fcloudshell%3Alatest&cloudshell_print=.%2Fmotd&cloudshell_tutorial=.%2Ftutorial.md&cloudshell_working_dir=Storage_pool_create&open_in_editor=main.tf" target="_blank">
-    <img alt="Open in Cloud Shell" src="//gstatic.com/cloudssh/images/open-btn.svg" style="max-height: 44px; margin: 32px auto; max-width: 100%;">
-  </a>
-</div>
-## Example Usage - Storage Pool Create
+## Example Usage - Storage Pool Create Doc
 
 
 ```hcl