Capitalize some function and variable names to make them public (#7368) (#13900)

* Capitalize some function and variable names to make them public

* Fix validator

* Keep pname

Signed-off-by: Modular Magician <magic-modules@google.com>

Author: modular-magician

.changelog/7368.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

google/access_context_manager_operation.go

@@ -33,7 +33,7 @@ func (w *AccessContextManagerOperationWaiter) QueryOp() (interface{}, error) {
 	// Returns the proper get.
 	url := fmt.Sprintf("%s%s", w.Config.AccessContextManagerBasePath, w.CommonOperationWaiter.Op.Name)
 
-	return sendRequest(w.Config, "GET", "", url, w.UserAgent, nil)
+	return SendRequest(w.Config, "GET", "", url, w.UserAgent, nil)
 }
 
 func createAccessContextManagerWaiter(config *Config, op map[string]interface{}, activity, userAgent string) (*AccessContextManagerOperationWaiter, error) {
@@ -48,7 +48,7 @@ func createAccessContextManagerWaiter(config *Config, op map[string]interface{},
 }
 
 // nolint: deadcode,unused
-func accessContextManagerOperationWaitTimeWithResponse(config *Config, op map[string]interface{}, response *map[string]interface{}, activity, userAgent string, timeout time.Duration) error {
+func AccessContextManagerOperationWaitTimeWithResponse(config *Config, op map[string]interface{}, response *map[string]interface{}, activity, userAgent string, timeout time.Duration) error {
 	w, err := createAccessContextManagerWaiter(config, op, activity, userAgent)
 	if err != nil {
 		return err
@@ -59,7 +59,7 @@ func accessContextManagerOperationWaitTimeWithResponse(config *Config, op map[st
 	return json.Unmarshal([]byte(w.CommonOperationWaiter.Op.Response), response)
 }
 
-func accessContextManagerOperationWaitTime(config *Config, op map[string]interface{}, activity, userAgent string, timeout time.Duration) error {
+func AccessContextManagerOperationWaitTime(config *Config, op map[string]interface{}, activity, userAgent string, timeout time.Duration) error {
 	if val, ok := op["name"]; !ok || val == "" {
 		// This was a synchronous call - there is no operation to wait for.
 		return nil

google/active_directory_operation.go

@@ -34,7 +34,7 @@ func (w *ActiveDirectoryOperationWaiter) QueryOp() (interface{}, error) {
 	// Returns the proper get.
 	url := fmt.Sprintf("%s%s", w.Config.ActiveDirectoryBasePath, w.CommonOperationWaiter.Op.Name)
 
-	return sendRequest(w.Config, "GET", w.Project, url, w.UserAgent, nil)
+	return SendRequest(w.Config, "GET", w.Project, url, w.UserAgent, nil)
 }
 
 func createActiveDirectoryWaiter(config *Config, op map[string]interface{}, project, activity, userAgent string) (*ActiveDirectoryOperationWaiter, error) {
@@ -50,7 +50,7 @@ func createActiveDirectoryWaiter(config *Config, op map[string]interface{}, proj
 }
 
 // nolint: deadcode,unused
-func activeDirectoryOperationWaitTimeWithResponse(config *Config, op map[string]interface{}, response *map[string]interface{}, project, activity, userAgent string, timeout time.Duration) error {
+func ActiveDirectoryOperationWaitTimeWithResponse(config *Config, op map[string]interface{}, response *map[string]interface{}, project, activity, userAgent string, timeout time.Duration) error {
 	w, err := createActiveDirectoryWaiter(config, op, project, activity, userAgent)
 	if err != nil {
 		return err
@@ -61,7 +61,7 @@ func activeDirectoryOperationWaitTimeWithResponse(config *Config, op map[string]
 	return json.Unmarshal([]byte(w.CommonOperationWaiter.Op.Response), response)
 }
 
-func activeDirectoryOperationWaitTime(config *Config, op map[string]interface{}, project, activity, userAgent string, timeout time.Duration) error {
+func ActiveDirectoryOperationWaitTime(config *Config, op map[string]interface{}, project, activity, userAgent string, timeout time.Duration) error {
 	if val, ok := op["name"]; !ok || val == "" {
 		// This was a synchronous call - there is no operation to wait for.
 		return nil

google/alloydb_operation.go

@@ -33,7 +33,7 @@ func (w *AlloydbOperationWaiter) QueryOp() (interface{}, error) {
 	// Returns the proper get.
 	url := fmt.Sprintf("%s%s", w.Config.AlloydbBasePath, w.CommonOperationWaiter.Op.Name)
 
-	return sendRequest(w.Config, "GET", w.Project, url, w.UserAgent, nil)
+	return SendRequest(w.Config, "GET", w.Project, url, w.UserAgent, nil)
 }
 
 func createAlloydbWaiter(config *Config, op map[string]interface{}, project, activity, userAgent string) (*AlloydbOperationWaiter, error) {
@@ -48,7 +48,7 @@ func createAlloydbWaiter(config *Config, op map[string]interface{}, project, act
 	return w, nil
 }
 
-func alloydbOperationWaitTime(config *Config, op map[string]interface{}, project, activity, userAgent string, timeout time.Duration) error {
+func AlloydbOperationWaitTime(config *Config, op map[string]interface{}, project, activity, userAgent string, timeout time.Duration) error {
 	if val, ok := op["name"]; !ok || val == "" {
 		// This was a synchronous call - there is no operation to wait for.
 		return nil

google/apigee_operation.go

@@ -33,7 +33,7 @@ func (w *ApigeeOperationWaiter) QueryOp() (interface{}, error) {
 	// Returns the proper get.
 	url := fmt.Sprintf("%s%s", w.Config.ApigeeBasePath, w.CommonOperationWaiter.Op.Name)
 
-	return sendRequest(w.Config, "GET", "", url, w.UserAgent, nil)
+	return SendRequest(w.Config, "GET", "", url, w.UserAgent, nil)
 }
 
 func createApigeeWaiter(config *Config, op map[string]interface{}, activity, userAgent string) (*ApigeeOperationWaiter, error) {
@@ -48,7 +48,7 @@ func createApigeeWaiter(config *Config, op map[string]interface{}, activity, use
 }
 
 // nolint: deadcode,unused
-func apigeeOperationWaitTimeWithResponse(config *Config, op map[string]interface{}, response *map[string]interface{}, activity, userAgent string, timeout time.Duration) error {
+func ApigeeOperationWaitTimeWithResponse(config *Config, op map[string]interface{}, response *map[string]interface{}, activity, userAgent string, timeout time.Duration) error {
 	w, err := createApigeeWaiter(config, op, activity, userAgent)
 	if err != nil {
 		return err
@@ -59,7 +59,7 @@ func apigeeOperationWaitTimeWithResponse(config *Config, op map[string]interface
 	return json.Unmarshal([]byte(w.CommonOperationWaiter.Op.Response), response)
 }
 
-func apigeeOperationWaitTime(config *Config, op map[string]interface{}, activity, userAgent string, timeout time.Duration) error {
+func ApigeeOperationWaitTime(config *Config, op map[string]interface{}, activity, userAgent string, timeout time.Duration) error {
 	if val, ok := op["name"]; !ok || val == "" {
 		// This was a synchronous call - there is no operation to wait for.
 		return nil

google/appengine_operation.go

@@ -30,7 +30,7 @@ func (w *AppEngineOperationWaiter) QueryOp() (interface{}, error) {
 	return w.Service.Apps.Operations.Get(w.AppId, matches[1]).Do()
 }
 
-func appEngineOperationWaitTimeWithResponse(config *Config, res interface{}, response *map[string]interface{}, appId, activity, userAgent string, timeout time.Duration) error {
+func AppEngineOperationWaitTimeWithResponse(config *Config, res interface{}, response *map[string]interface{}, appId, activity, userAgent string, timeout time.Duration) error {
 	op := &appengine.Operation{}
 	err := Convert(res, op)
 	if err != nil {
@@ -51,7 +51,7 @@ func appEngineOperationWaitTimeWithResponse(config *Config, res interface{}, res
 	return json.Unmarshal([]byte(w.CommonOperationWaiter.Op.Response), response)
 }
 
-func appEngineOperationWaitTime(config *Config, res interface{}, appId, activity, userAgent string, timeout time.Duration) error {
+func AppEngineOperationWaitTime(config *Config, res interface{}, appId, activity, userAgent string, timeout time.Duration) error {
 	op := &appengine.Operation{}
 	err := Convert(res, op)
 	if err != nil {

google/artifact_registry_operation.go

@@ -34,7 +34,7 @@ func (w *ArtifactRegistryOperationWaiter) QueryOp() (interface{}, error) {
 	// Returns the proper get.
 	url := fmt.Sprintf("%s%s", w.Config.ArtifactRegistryBasePath, w.CommonOperationWaiter.Op.Name)
 
-	return sendRequest(w.Config, "GET", w.Project, url, w.UserAgent, nil)
+	return SendRequest(w.Config, "GET", w.Project, url, w.UserAgent, nil)
 }
 
 func createArtifactRegistryWaiter(config *Config, op map[string]interface{}, project, activity, userAgent string) (*ArtifactRegistryOperationWaiter, error) {
@@ -50,7 +50,7 @@ func createArtifactRegistryWaiter(config *Config, op map[string]interface{}, pro
 }
 
 // nolint: deadcode,unused
-func artifactRegistryOperationWaitTimeWithResponse(config *Config, op map[string]interface{}, response *map[string]interface{}, project, activity, userAgent string, timeout time.Duration) error {
+func ArtifactRegistryOperationWaitTimeWithResponse(config *Config, op map[string]interface{}, response *map[string]interface{}, project, activity, userAgent string, timeout time.Duration) error {
 	w, err := createArtifactRegistryWaiter(config, op, project, activity, userAgent)
 	if err != nil {
 		return err
@@ -61,7 +61,7 @@ func artifactRegistryOperationWaitTimeWithResponse(config *Config, op map[string
 	return json.Unmarshal([]byte(w.CommonOperationWaiter.Op.Response), response)
 }
 
-func artifactRegistryOperationWaitTime(config *Config, op map[string]interface{}, project, activity, userAgent string, timeout time.Duration) error {
+func ArtifactRegistryOperationWaitTime(config *Config, op map[string]interface{}, project, activity, userAgent string, timeout time.Duration) error {
 	if val, ok := op["name"]; !ok || val == "" {
 		// This was a synchronous call - there is no operation to wait for.
 		return nil

google/batcher.go

@@ -10,7 +10,7 @@ import (
 	"github.com/hashicorp/errwrap"
 )
 
-const defaultBatchSendIntervalSec = 3
+const DefaultBatchSendIntervalSec = 3
 
 // RequestBatcher keeps track of batched requests globally.
 // It should be created at a provider level. In general, one
@@ -98,8 +98,8 @@ type batchSubscriber struct {
 
 // batchingConfig contains user configuration for controlling batch requests.
 type batchingConfig struct {
-	sendAfter      time.Duration
-	enableBatching bool
+	SendAfter      time.Duration
+	EnableBatching bool
 }
 
 // Initializes a new batcher.
@@ -161,7 +161,7 @@ func (b *RequestBatcher) SendRequestWithTimeout(batchKey string, request *BatchR
 	if request.SendF == nil {
 		return nil, fmt.Errorf("error, cannot request batching for BatchRequest with nil SendF")
 	}
-	if !b.enableBatching {
+	if !b.EnableBatching {
 		log.Printf("[DEBUG] Batching is disabled, sending single request for %q", request.DebugId)
 		return request.SendF(request.ResourceName, request.Body)
 	}
@@ -243,7 +243,7 @@ func (b *RequestBatcher) registerBatchRequest(batchKey string, newRequest *Batch
 	}
 
 	// Start a timer to send the request
-	b.batches[batchKey].timer = time.AfterFunc(b.sendAfter, func() {
+	b.batches[batchKey].timer = time.AfterFunc(b.SendAfter, func() {
 		batch := b.popBatch(batchKey)
 		if batch == nil {
 			log.Printf("[ERROR] batch should have been added to saved batches - just run as single request %q", newRequest.DebugId)

google/batcher_test.go

@@ -24,8 +24,8 @@ func TestRequestBatcher_disableBatching(t *testing.T) {
 		"testBatcher",
 		context.Background(),
 		&batchingConfig{
-			sendAfter:      time.Duration(1) * time.Second,
-			enableBatching: false,
+			SendAfter:      time.Duration(1) * time.Second,
+			EnableBatching: false,
 		})
 
 	testCombine := func(currV interface{}, toAddV interface{}) (interface{}, error) {
@@ -72,8 +72,8 @@ func TestRequestBatcher_errInCombine(t *testing.T) {
 		"testBatcher",
 		context.Background(),
 		&batchingConfig{
-			sendAfter:      time.Duration(5) * time.Second,
-			enableBatching: true,
+			SendAfter:      time.Duration(5) * time.Second,
+			EnableBatching: true,
 		})
 
 	combineErrText := "this is an expected error in combine"
@@ -136,8 +136,8 @@ func TestRequestBatcher_errInSend(t *testing.T) {
 		"testBatcher",
 		context.Background(),
 		&batchingConfig{
-			sendAfter:      time.Duration(5) * time.Second,
-			enableBatching: true,
+			SendAfter:      time.Duration(5) * time.Second,
+			EnableBatching: true,
 		})
 
 	// combineF keeps track of the batched indexes
@@ -205,8 +205,8 @@ func TestRequestBatcher_errTimeout(t *testing.T) {
 		"testBatcher",
 		context.Background(),
 		&batchingConfig{
-			sendAfter:      time.Duration(5) * time.Second,
-			enableBatching: true,
+			SendAfter:      time.Duration(5) * time.Second,
+			EnableBatching: true,
 		})
 
 	testResource := "resource for send error"
@@ -250,8 +250,8 @@ func testBasicCountBatches(t *testing.T, testName string, numBatches int) {
 		"testBatcher",
 		context.Background(),
 		&batchingConfig{
-			sendAfter:      time.Duration(1) * time.Second,
-			enableBatching: true,
+			SendAfter:      time.Duration(1) * time.Second,
+			EnableBatching: true,
 		})
 
 	testCombine := func(currV interface{}, toAddV interface{}) (interface{}, error) {

google/beyondcorp_operation.go

@@ -34,7 +34,7 @@ func (w *BeyondcorpOperationWaiter) QueryOp() (interface{}, error) {
 	// Returns the proper get.
 	url := fmt.Sprintf("%s%s", w.Config.BeyondcorpBasePath, w.CommonOperationWaiter.Op.Name)
 
-	return sendRequest(w.Config, "GET", w.Project, url, w.UserAgent, nil)
+	return SendRequest(w.Config, "GET", w.Project, url, w.UserAgent, nil)
 }
 
 func createBeyondcorpWaiter(config *Config, op map[string]interface{}, project, activity, userAgent string) (*BeyondcorpOperationWaiter, error) {
@@ -50,7 +50,7 @@ func createBeyondcorpWaiter(config *Config, op map[string]interface{}, project,
 }
 
 // nolint: deadcode,unused
-func beyondcorpOperationWaitTimeWithResponse(config *Config, op map[string]interface{}, response *map[string]interface{}, project, activity, userAgent string, timeout time.Duration) error {
+func BeyondcorpOperationWaitTimeWithResponse(config *Config, op map[string]interface{}, response *map[string]interface{}, project, activity, userAgent string, timeout time.Duration) error {
 	w, err := createBeyondcorpWaiter(config, op, project, activity, userAgent)
 	if err != nil {
 		return err
@@ -61,7 +61,7 @@ func beyondcorpOperationWaitTimeWithResponse(config *Config, op map[string]inter
 	return json.Unmarshal([]byte(w.CommonOperationWaiter.Op.Response), response)
 }
 
-func beyondcorpOperationWaitTime(config *Config, op map[string]interface{}, project, activity, userAgent string, timeout time.Duration) error {
+func BeyondcorpOperationWaitTime(config *Config, op map[string]interface{}, project, activity, userAgent string, timeout time.Duration) error {
 	if val, ok := op["name"]; !ok || val == "" {
 		// This was a synchronous call - there is no operation to wait for.
 		return nil