Skip to content

Add field reserved_internal_range and range to allow integration with the Internal Ranges API #17881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments

@daanheikens
Copy link

daanheikens commented Apr 17, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

Recently the Internal Ranges API became Generally Available to be used. Integration with the subnetwork resource was not yet present aswell as the Internal Ranges API resource. (PR here: GoogleCloudPlatform/magic-modules#10465)

To integrate the Internal Ranges API with the Subnetwork resource, the field reserved_internal_range needs to be added. The gcloud sdk also provides the range argument but this seems to be a gcloud specific argument.

New or Affected Resource(s)

  • google_compute_subnetwork

Potential Terraform Configuration

resource "google_compute_subnetwork" "full_range" {
  name                     = "full-range"
  region                   = "europe-west4"
  network                  = google_compute_network.default.name
  reserved_internal_range  = google_network_connectivity_internal_range.default.id
  private_ip_google_access = true
}

# OR

resource "google_compute_subnetwork" "partial_range" {
  name                     = "partial_range"
  region                   = "europe-west4"
  network                  = google_compute_network.default.name
  reserved_internal_range  = google_network_connectivity_internal_range.default.id
  ip_cidr_range            = "10.0.0.0/29"
  private_ip_google_access = true
}

References

https://cloud.google.com/network-connectivity/docs/reference/networkconnectivity/rest/v1/projects.locations.internalRanges
https://cloud.google.com/compute/docs/reference/rest/v1/subnetworks

b/336319050

@github-actions github-actions bot added forward/review In review; remove label to forward service/compute-vpc labels Apr 17, 2024
@daanheikens
Copy link
Author

Since this PR: GoogleCloudPlatform/magic-modules#10465 is now merged, this one can be picked up. Will do that asap to integrate the subnetworks with the Internal Ranges API.

@c2thorn
Copy link
Collaborator

c2thorn commented Jun 5, 2024

@daanheikens can you resend the pull request and ping @trodge on it? It will sit until the 6.0.0 feature branches are ready

@trodge you should apply the "stop review reminders" label to it

@daanheikens
Copy link
Author

@daanheikens can you resend the pull request and ping @trodge on it? It will sit until the 6.0.0 feature branches are ready

@trodge you should apply the "stop review reminders" label to it

Sure! Will do that. I believe it does require some extra effort to fix the issue in which i do need some support with. I will make sure to raise my questions on the PR. Thanks @c2thorn

@c2thorn
Copy link
Collaborator

c2thorn commented Aug 19, 2024

This has been added to the 6.0 branch. The breaking change part of it has moved to a part of #12824

The new field will no longer be a breaking change, but the removal of schema.ConfigModeAttr to the parent field will be.

@c2thorn c2thorn closed this as completed Aug 19, 2024
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.