Skip to content

Fix some wrong and missing GKE network config docs #18295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modular-magician
Copy link
Collaborator

network_performance_config was nested under advanced_machine_features in cluster, it's actually under network_config in node pool. I found a missing field in docs at the same time.

Original PR was GoogleCloudPlatform/magic-modules#6826

Release Note Template for Downstream PRs (will be copied)

Derived from GoogleCloudPlatform/magic-modules#10849

Co-authored-by: Zhenhua Li <zhenhuali@google.com>

[upstream:7c6c2b7517578d7da20ce8eae99d37f34aa20a05]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 29bb502 into hashicorp:main May 31, 2024
4 checks passed
Copy link

github-actions bot commented Jul 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2024
@modular-magician modular-magician deleted the downstream-pr-7c6c2b7517578d7da20ce8eae99d37f34aa20a05 branch November 16, 2024 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant