Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common Release Tooling onboarding #397

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Common Release Tooling onboarding #397

merged 2 commits into from
Feb 12, 2025

Conversation

bbasata
Copy link
Contributor

@bbasata bbasata commented Feb 12, 2025 •
edited
Loading

Copy-modified from the terraform-provider-cloudinit reference example:

$ cd terraform-provider-null
mkdir version .release

# Copy files from cloudinit
tar c -C ../terraform-provider-cloudinit .release/ .github/workflows/build.yml | tar x

# Replace 'cloudinit' using GNU sed
gsed -e -i 's/cloudinit/null/g' .release/* .github/workflows/build.yml

echo "3.2.3-dev" >> version/VERSION

@bbasata bbasata marked this pull request as ready for review February 12, 2025 18:21
@bbasata bbasata requested a review from a team as a code owner February 12, 2025 18:21
@bbasata
Copy link
Contributor Author

bbasata commented Feb 12, 2025

Failing check is addressed in #398

austinvalle
austinvalle reviewed Feb 12, 2025
View reviewed changes
@bbasata bbasata enabled auto-merge (squash) February 12, 2025 20:03
austinvalle
austinvalle approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bbasata bbasata merged commit 6ea86aa into main Feb 12, 2025
52 checks passed
@bbasata bbasata deleted the crt-onboarding branch February 12, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinvalle austinvalle austinvalle approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbasata @austinvalle