Refactor 1: Do not install AWS

Author: kosyfrances

modules/tfe_init_replicated/functions.tf

@@ -4,6 +4,7 @@
 locals {
   get_base64_secrets = templatefile("${path.module}/templates/get_base64_secrets.func", {
     cloud = var.cloud
+    distribution = var.distribution
   })
 
   install_packages = templatefile("${path.module}/templates/install_packages.func", {

modules/tfe_init_replicated/templates/get_base64_secrets.func

@@ -11,10 +11,15 @@ function get_base64_secrets {
 
 %{ if cloud == "aws" ~}
 function get_base64_secrets {
-	# Description: Pull the Base 64 encoded secrets from AWS Secrets Manager
 	local secret_id=$1
-	# OS: Agnostic
-	/usr/local/bin/aws secretsmanager get-secret-value --secret-id $secret_id | jq --raw-output '.SecretBinary,.SecretString | select(. != null)'
+	%{ if distribution == "amazon-linux-2023" ~}
+		# Amazon Linux 2023 already has AWS installed on the machine
+		aws secretsmanager get-secret-value --secret-id $secret_id | jq --raw-output '.SecretBinary,.SecretString | select(. != null)'
+	%{ else ~}
+		# OS: Agnostic
+		# Description: Pull the Base 64 encoded secrets from AWS Secrets Manager
+		/usr/local/bin/aws secretsmanager get-secret-value --secret-id $secret_id | jq --raw-output '.SecretBinary,.SecretString | select(. != null)'
+	%{ endif ~}
 }
 %{ endif ~}
 

modules/tfe_init_replicated/templates/install_packages.func

@@ -36,12 +36,15 @@ function install_packages {
 		%{ endif ~}
 	%{ endif ~}
 
-	echo "[$(date +"%FT%T")] [Terraform Enterprise] Install AWS CLI" | tee -a $log_pathname
-	curl --noproxy '*' "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o "awscliv2.zip"
-	unzip awscliv2.zip
-	./aws/install
-	rm -f ./awscliv2.zip
-	rm -rf ./aws
+	# Amazon Linux 2023 already has AWS installed on the machine so no need to install it there.
+	%{ if distribution != "amazon-linux-2023" ~}
+		echo "[$(date +"%FT%T")] [Terraform Enterprise] Install AWS CLI" | tee -a $log_pathname
+		curl --noproxy '*' "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o "awscliv2.zip"
+		unzip awscliv2.zip
+		./aws/install
+		rm -f ./awscliv2.zip
+		rm -rf ./aws
+	%{ endif ~}
 }
 %{ endif ~}