Skip to content

[TF-15186] Upgrade HCP provider in vault fixture to ~> 0.90.0 #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024

Conversation

miguelhrocha
Copy link

@miguelhrocha miguelhrocha commented May 23, 2024

Background

The latest version of the provider allows configuring a project_id, which we need for using this module in other HCP projects inside the tf-onprem-dev-org.

Merging is pretty safe, as this does not affect the public modules in any way. It is a fixture used by some examples, and module tests which we don't run anymore.

@miguelhrocha miguelhrocha requested a review from a team as a code owner May 23, 2024 10:12
@miguelhrocha miguelhrocha merged commit 4761b53 into main May 23, 2024
4 checks passed
@miguelhrocha miguelhrocha deleted the TF-15186-external-vault-upgrade-provider branch May 23, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants